New issue
Advanced search Search tips

Issue 916058 link

Starred by 1 user
Status: Fixed
Owner:
atotic@chromium.org
Closed: Dec 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task



Sign in to add a comment

Run LayoutNG bot on more directories

Project Member Reported by atotic@chromium.org, Dec 18 
LayoutNG tests sometimes suffer large breakage when a CL breaks many existing image tests, rebaselines them, but does not rebaseline flag-specific tests.

This happens most often with large rendering changes (ex: new skia).

To fix this, LayoutNG team would like to run LayoutNG build bot when certain directories change.

Running NG bot any time third_party/blink/web_tests changes would catch all test rebaselines, but might cause our bot to run much more often than really needed.

We will start by adding a few directories that we know caused breakage in the past.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1f315e5c53b7481f74df1b2ff18318ed36af565

commit e1f315e5c53b7481f74df1b2ff18318ed36af565
Author: Aleks Totic <atotic@chromium.org>
Date: Tue Dec 18 22:35:32 2018

[LayoutNG] Run LayoutNG bot for more directories

LayoutNG tests often do not get rebaselined when they should be.
Common scenario is a change in painting that causes many tests
to need rebaseline. This gets done for main tests, but not for NG.

This CL triggers NG bot for more directories:
Old:
third_party/blink/renderer/core/layout/ng
third_party/blink/renderer/core/paint/ng
New:
third_party/blink/renderer/core/layout/.+"
third_party/blink/renderer/core/paint/.+"
third_party/blink/renderer/core/svg/.+"
third_party/blink/renderer/platform/graphics/.+

Another option was to trigger NG bot for
third_party/blink/web_tests

This would make sure that NG bot gets triggered
for every test rebaseline. My concern was that this
would trigger too often.

Bug:  916058 
Change-Id: I82fbeadccc209373cd7ad249c8b389a7d8646679
Reviewed-on: https://chromium-review.googlesource.com/c/1383134
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617656}
[modify] https://crrev.com/e1f315e5c53b7481f74df1b2ff18318ed36af565/docs/infra/cq_builders.md
[modify] https://crrev.com/e1f315e5c53b7481f74df1b2ff18318ed36af565/infra/config/branch/cq.cfg

Comment 2 by atotic@chromium.org, Dec 18

Status: Fixed (was: Started)
►

Sign in to add a comment