New issue
Advanced search Search tips

Issue 916025 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Proj-Servicification



Sign in to add a comment

--explicitly-allowed-ports CLI option is ignored

Reported by xmillsa@tutanota.com, Dec 18

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3624.2 Safari/537.36

Steps to reproduce the problem:
1. Run chrome.exe with --explicitly-allowed-ports=139 flag
2. Navigate to localhost:139

What is the expected behavior?
Connect to the port.

What went wrong?
Unsafe port error.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 72.0.3624.2  Channel: canary
OS Version: 6.3
Flash Version: /
 
Labels: Needs-Triage-M72
Cc: viswa.karala@chromium.org
Labels: Triaged-ET Needs-Feedback
Tried testing the issue on chrome reported version# 72.0.3624.2 using Windows-10 with steps mentioned below:
1) Launched chrome reported version from terminal with --explicitly-allowed-ports=139
2) On chrome windows navigated to  localhost:139, seen ERR_CONNECTION_REFUSED

@Reporter: Please find the above mentioned information and provide your feedback on it which help in further triaging the issue.

Thanks!
916025.png
76.3 KB View Download
Not sure what to say. We are consistently able to reproduce the issue on our Windows 10 PC. We can provide our virtual machine, if necessary.
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 22

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: yhirano@chromium.org
Components: -Blink>Network Internals>Network
Components: Internals>Services>Network
I can reproduce when the Network Service is enabled (chrome://flags/#network-service)
Owner: eroman@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e21a4586f8dd69348f0a30fb20772ab912afd1

commit e6e21a4586f8dd69348f0a30fb20772ab912afd1
Author: Eric Roman <eroman@chromium.org>
Date: Tue Jan 08 22:35:26 2019

Make --explicitly-allowed-ports work with NetworkService.

This also makes it work in content_shell, whereas previously it was only wired up in chrome.

Bug:  916025 
Change-Id: Ic79e478d02160e2cb0727a22495c029f21447796
Reviewed-on: https://chromium-review.googlesource.com/c/1400042
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620910}
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/chrome/browser/ui/startup/startup_browser_creator.cc
[add] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/content/browser/net/net_command_line_flags_browsertest.cc
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/content/browser/utility_process_host.cc
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/content/public/common/content_switches.cc
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/content/public/common/content_switches.h
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/content/test/BUILD.gn
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/services/network/network_service.cc
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/services/network/public/cpp/network_switches.cc
[modify] https://crrev.com/e6e21a4586f8dd69348f0a30fb20772ab912afd1/services/network/public/cpp/network_switches.h

Status: Fixed (was: Assigned)

Sign in to add a comment