New issue
Advanced search Search tips

Issue 916012 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tast's -checkbuilddeps flag shouldn't suggest installing RDEPEND dependencies

Project Member Reported by derat@chromium.org, Dec 18

Issue description

By default, "tast run -build=true" checks that tast-local-tests-cros-9999's dependencies (which are needed to build the test bundle) are installed for the host. To get the list, it parses the output from "equery -q -C g --depth=1 chromeos-base/tast-local-test-runner-9999".

Unfortunately, the output includes both DEPEND and RDEPEND (and post-merge dependencies), so we end up telling developers to install runtime dependencies that we don't actually need or want.

I can't find any way to limit "equery g"'s output to build dependencies.

Maybe running emerge with --onlydeps, --onlydeps-with-rdeps n, and --pretend could provide the correct info, but that command seems slower than I'd like (2+ seconds rather than ~500ms like "equery g").

I thought about sourcing the ebuild and dropping packages in RDEPEND (maybe if they're not also in DEPEND), but that won't correctly handle dependencies coming from eclasses.
 
Side note:
Does Chromium's emerge command need to be updated to include the "--onlydeps-with-rdeps=n" flag? Trying to use it manually resulted in failure (emerge thought it was a package on my dev machine).
sometimes portage's CLI parser is ... bad.  --foo=blah and --foo blah aren't the same.  Dan didn't use a = in his option, so maybe check that ?
cros ~/trunk/src/platform/tast$ emerge --onlydeps --onlydeps-with-rdeps=n --pretend tast-local-tests-cros                                                                                                                                                                       
!!! '--onlydeps-with-rdeps=n' is not a valid package atom.                                                                                                                                                                                                                      
!!! Please check ebuild(5) for full details.

(The man page implied there shouldn't be an equal sign, IIRC.)

Comment 4 by derat@chromium.org, Jan 18 (5 days ago)

Status: Started (was: Assigned)

Sign in to add a comment