New issue
Advanced search Search tips

Issue 916009 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression

Blocking:
issue 883427



Sign in to add a comment

RAR support broken when DriveFS is enabled.

Reported by amistryt...@gmail.com, Dec 18

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 11316.18.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.15 Safari/537.36

Steps to reproduce the problem:
1. Enable DriveFS
2. Attempt to mount a RAR file stored in drive.

What is the expected behavior?
Works.

What went wrong?
error_internal pops up. cros-disks errors are seen in logs:
2018-12-18T04:07:38.435204+00:00 ERR cros-disks[1630]: Failed to get real path of '/media/fuse/drivefs-f2877226af4eea0c2f744e3bf7bd67ce/root/images.rar': Permission denied
2018-12-18T04:07:38.436997+00:00 ERR cros-disks[1630]: Failed to mount '/run/avfsroot/media/fuse/drivefs-f2877226af4eea0c2f744e3bf7bd67ce/root/images.rar#urar' '/media/archive/images.rar' '' 4110 '': Permission denied
2018-12-18T04:07:38.437079+00:00 ERR cros-disks[1630]: Failed to mount '/run/avfsroot/media/fuse/drivefs-f2877226af4eea0c2f744e3bf7bd67ce/root/images.rar#urar' to '/media/archive/images.rar' as filesystem '' with options 'bind,rw,nodev,noexec,nosuid'
2018-12-18T04:07:38.437125+00:00 ERR cros-disks[1630]: Failed to mount path '/media/fuse/drivefs-f2877226af4eea0c2f744e3bf7bd67ce/root/images.rar'
2018-12-18T04:07:38.437203+00:00 ERR cros-disks[1630]: Failed to mount '/media/fuse/drivefs-f2877226af4eea0c2f744e3bf7bd67ce/root/images.rar'

Did this work before? N/A 

Chrome version: 72.0.3626.15  Channel: dev
OS Version: 11316.18.0
Flash Version:
 
Cc: sa...@chromium.org dats@chromium.org amistry@chromium.org
Components: Platform>Apps>FileManager
Labels: CrOSFilesFeature-DriveSync CrOSFilesFeature-Zip
Status: Available (was: Unconfirmed)
Blocking: 883427
Owner: sa...@chromium.org
Status: Assigned (was: Available)
The root cause is that cros-disks doesn't have execute permission on /media/fuse/drivefs-f2877226af4eea0c2f744e3bf7bd67ce (and possibly on the children too), which causes mount to fail with a permission problem.

It also causes the "real path" error, which works by walking the directory path and lstat-ing each component along the way.

Assigning to Sam since this is a drivefs issue.
Owner: dats@chromium.org
Labels: Target-73 Treadstone
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 24

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/9c698dd5cf523fe25471c15357c1ff90f0705852

commit 9c698dd5cf523fe25471c15357c1ff90f0705852
Author: Sam McNally <sammc@google.com>
Date: Mon Dec 24 07:52:05 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/drivefs/+/e2083b34de807a492af6a96f64099bbdaae3cf2b

commit e2083b34de807a492af6a96f64099bbdaae3cf2b
Author: Sergei Datsenko <dats@google.com>
Date: Fri Dec 28 05:01:16 2018

Status: Fixed (was: Assigned)

Sign in to add a comment