Findit identified the culprit r617338 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDAxOGMwNzZlODVkNzVkOGE3MmVmNGE3ZjhhZGY1M2JlZGI0YjBiZAw Please revert the culprit, or disable the test(s) and find the appropriate owner to fix or delete. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r617338&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDAxOGMwNzZlODVkNzVkOGE3MmVmNGE3ZjhhZGY1M2JlZGI0YjBiZAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22ccebfe9229626c14dec05eceebf322d83185a4 commit 22ccebfe9229626c14dec05eceebf322d83185a4 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Dec 18 03:35:08 2018 Revert "Reland: [Accessibility] Volume slider reads out level in percentages." This reverts commit d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 617338 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDAxOGMwNzZlODVkNzVkOGE3MmVmNGE3ZjhhZGY1M2JlZGI0YjBiZAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/17415 Sample Failed Step: single_process_mash_content_browsertests Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls Original change's description: > Reland: [Accessibility] Volume slider reads out level in percentages. > > This is a reland of change I0ee5a91215669f39c7394d3c8f113ae83a74cf00 > > This CL makes it such that the volume level is read out as a percentage > in aria. This CL also amplifies how the accessibility information is > given to aria, by setting attributes instead of explicitly creating > accessibility nodes. > > TBR=thakis@chromium.org > > Bug: 905024 > Change-Id: I831d9ed1f1790556d1a58431f3aaf9562c2c9043 > Reviewed-on: https://chromium-review.googlesource.com/c/1373032 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617338} Change-Id: I18c48f0c2f1c732e6be8b74690360382f6c7f3d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905024 , 916003 Reviewed-on: https://chromium-review.googlesource.com/c/1381725 Cr-Commit-Position: refs/heads/master@{#617365} [modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [delete] https://crrev.com/f28bd2cc028ea9886e33a55a25c8ec03c380261a/content/test/data/accessibility/html/video-controls-expected-auralinux.txt [delete] https://crrev.com/f28bd2cc028ea9886e33a55a25c8ec03c380261a/content/test/data/accessibility/html/video-controls-expected-blink.txt [delete] https://crrev.com/f28bd2cc028ea9886e33a55a25c8ec03c380261a/content/test/data/accessibility/html/video-controls.html [modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter [delete] https://crrev.com/f28bd2cc028ea9886e33a55a25c8ec03c380261a/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html [modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc [modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/third_party/blink/renderer/modules/accessibility/ax_media_controls.h [modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc [modify] https://crrev.com/22ccebfe9229626c14dec05eceebf322d83185a4/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b commit 70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Dec 26 21:36:48 2018 Revert "Reland "Reland: [Accessibility] Volume slider reads out level in percentages."" This reverts commit 543a2def162aeb06e9709ed4b8e4f074d9d8c18e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 618940 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTQzYTJkZWYxNjJhZWIwNmU5NzA5ZWQ0YjhlNGYwNzRkOWQ4YzE4ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/5873 Sample Failed Step: network_service_content_browsertests on Ubuntu-16.04 Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls Original change's description: > Reland "Reland: [Accessibility] Volume slider reads out level in percentages." > > This is a reland of d018c076e85d75d8a72ef4a7f8adf53bedb4b0bd > > Original change's description: > > Reland: [Accessibility] Volume slider reads out level in percentages. > > > > This is a reland of change I0ee5a91215669f39c7394d3c8f113ae83a74cf00 > > > > This CL makes it such that the volume level is read out as a percentage > > in aria. This CL also amplifies how the accessibility information is > > given to aria, by setting attributes instead of explicitly creating > > accessibility nodes. > > > > TBR=thakis@chromium.org > > > > Bug: 905024 > > Change-Id: I831d9ed1f1790556d1a58431f3aaf9562c2c9043 > > Reviewed-on: https://chromium-review.googlesource.com/c/1373032 > > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#617338} > > TBR=thakis@chromium.org,dmazzoni@chromium.org,mlamouri@chromium.org > > Bug: 905024 > Change-Id: Ie308a4b30032491333072681fcf214a9fab58d5c > Reviewed-on: https://chromium-review.googlesource.com/c/1383307 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618940} Change-Id: I3dca4908cc62c213585bc99eefe73f114bd55fe9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905024 , 916003 Reviewed-on: https://chromium-review.googlesource.com/c/1391326 Cr-Commit-Position: refs/heads/master@{#618963} [modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [delete] https://crrev.com/e7caa7ca82fc015675aea8cecf178c83a94ab3a7/content/test/data/accessibility/html/video-controls-expected-auralinux.txt [delete] https://crrev.com/e7caa7ca82fc015675aea8cecf178c83a94ab3a7/content/test/data/accessibility/html/video-controls-expected-blink.txt [delete] https://crrev.com/e7caa7ca82fc015675aea8cecf178c83a94ab3a7/content/test/data/accessibility/html/video-controls.html [delete] https://crrev.com/e7caa7ca82fc015675aea8cecf178c83a94ab3a7/third_party/WebKit/LayoutTests/media/controls/accessibility-volume-slider.html [modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc [modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/third_party/blink/renderer/modules/accessibility/ax_media_controls.h [modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc [modify] https://crrev.com/70a1fffbdceeb2a4ad0a5e22c255f4ca12a6597b/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
Comment 1 by bugdroid1@chromium.org
, Dec 18