Issue metadata
Sign in to add a comment
|
[Enterprise] Cannot configure fields and connect to policy pushed OpenVPN and 802.1x wireless networks. |
||||||||||||||||||||||
Issue descriptionChrome Version: <From about:version: Google Chrome 72.0.3626.22> Chrome OS Version: <From about:version: Platform 11316.29.0> Chrome OS Platform: <Robo360> Network info: <VPN> Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) On chrome://settings page, select policy pushed vpn network and click configure. Error Logs: Error in response to networkingPrivate.getManagedProperties: TypeError: Cannot use 'in' operator to search for 'Effective' in true chrome://settings/networkDetail?guid=%7Bb83beb2b-495a-4b44-86ff-97b6018a99a7%7D&type=WiFi&name=CrOS_WPA2_LinksysE3000N_5GHz:1 Error in response to networkingPrivate.getManagedProperties: TypeError: Cannot use 'in' operator to search for 'Effective' in true 2networkDetail:1 Error in response to networkingPrivate.getManagedProperties: TypeError: Cannot use 'in' operator to search for 'Effective' in true Expected Result: Configuration panel for the openvpn network. Actual Result: pop up which does not have configuration field (check screenshot). How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always for policy pushed openvpn network. I cannot reproduce for some other policy pushed network (for ex: ipsec) What is the impact to the user, and is there a workaround? If so, what is it? Nope. Please provide any additional information below. Attach a screen shot or log if possible. screenshot attached. report link @ https://listnr.corp.google.com/report/85852763650 For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Dec 18
This is likely related to this semi-recent change: https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js?dr&q=cr_onc&sq=package:chromium&g=0&l=304
,
Dec 18
Hi, Could you please provide configuration in ONC format for this policy pushed vpn network?
,
Dec 18
The issue is happening for EAP-TLS policy configured networks also. I cannot connect to the network either.
{
"GUID": "{cb17b646-e77c-4449-b345-466148ed51c5}",
"Name": "OpenVPN",
"ProxySettings": {
"Type": "Direct"
},
"Type": "VPN",
"VPN": {
"AutoConnect": false,
"Host": "openvpn",
"OpenVPN": {
"AuthRetry": "interact",
"ClientCertType": "None",
"Password": "********",
"Port": 1192,
"Proto": "udp",
"Recommended": [ "Username", "Password" ],
"SaveCredentials": true,
"ServerCARef": "{fc2e9410-4d17-46e5-aa7c-97387767af94}",
"Username": "openvpn"
},
"Type": "OpenVPN"
}
},
"Type": "Ethernet"
}, {
"GUID": "{b83beb2b-495a-4b44-86ff-97b6018a99a7}",
"Name": "EAP-TLS- Enterprise-Temporary (Other being used for dynamic WEP)",
"ProxySettings": {
"Type": "Direct"
},
"Type": "WiFi",
"WiFi": {
"AutoConnect": false,
"EAP": {
"ClientCertPattern": {
"EnrollmentURI": [ "http://www.radius.com/certs/download.php" ],
"Issuer": {
"CommonName": "radius-ca",
"Organization": "Google",
"OrganizationalUnit": "ChromeOS"
},
"Subject": {
"CommonName": "radius-client",
"Organization": "Google",
"OrganizationalUnit": "ChromeOS"
}
},
"ClientCertType": "Pattern",
"Identity": "CrOS",
"Outer": "EAP-TLS",
"Recommended": [ "AnonymousIdentity", "Password" ],
"SaveCredentials": true,
"ServerCARef": "{ec4cb0aa-25a4-4e7b-9e6f-b71def059de0}",
"UseSystemCAs": true
},
"HiddenSSID": false,
"SSID": "CrOS_WPA2_LinksysE3000N_5GHz",
"Security": "WPA-EAP"
}
},
plus Marking as a Beta blocker.
,
Dec 18
aashutoshk@- This issue was marked as blocking M72 Beta. M72 Beta is targeted for tomorrow. Was this issue introduced in M72? Do we know how many Enterprise users are on Beta? If Enterprise users are not usually on Beta, can we move to ReleaseBlock-Stable? Are there any workarounds for this issue?
,
Dec 18
Was this issue introduced in M72? >>Yes, This is M72 specific. I don't see this issue on M71. Do we know how many Enterprise users are on Beta? If Enterprise users are not usually on Beta, can we move to ReleaseBlock-Stable? >> No idea. Ccing few more people who may have some idea. Are there any workarounds for this issue? >> Nope.
,
Dec 18
Discussed with aashutoshk@ regarding the configuration, checked and observed the device cannot connect to the configured network. Google Chrome(72.0.3626.22,11316.29.0) robo Attached logs. Additional Information: Able to install the certificate and successfully connect to Google-A network.
,
Dec 18
Attached logs.
,
Dec 18
,
Dec 19
The bug is associated with only "UserEditable/DeviceEditable" fields in ManagedProperties (https://cs.chromium.org/chromium/src/third_party/closure_compiler/externs/networking_private.js?q=networking_private.js&sq=package:chromium&dr&l=128). In this case it's OpenVPNProperties.OTP. There is CL fixing this bug: https://chromium-review.googlesource.com/c/chromium/src/+/1335487 voit@ is going to submit it during next week.
,
Dec 19
,
Dec 19
The patch in 1335487 does more than just fix this bug, can we put up a CL that just fixes cr_onc_types.js (which I assume is where the bug is)?
,
Dec 19
I'm against pushing this to Beta. Many of our customers have been burned recently when it comes to our networking changes. It's true that most of our users are on Stable channel, but most != all. We cannot both actively encourage customers to put a % of their devices on Beta channel and also push a bug like this. Can someone from Support and Enterprise PM team please weigh in too?
,
Dec 19
agreed, we should not push this if we believe it will break enterprises on beta.
,
Dec 19
+1 to not pushing known significant regressions to beta please
,
Dec 19
Makes sense .. Do we have autotest to catch this earlier next time?
,
Dec 19
Thank you for the input everyone. Leaving this issue as a ReleaseBlock-Beta. We will target M72 Beta after the holidays.
,
Dec 19
UI issues are very difficult to test. We have hundreds of permutations making an exhaustive test prohibited. That said, we could and should add a comprehensive browser test for the network configuration UI that would catch this and some other issues we have seen in the past. It's just a matter of prioritizing the work.
,
Dec 19
Marking as P0 as this is blocking M-72 Beta and M-73 Dev.
,
Dec 19
I've created a doc detailing limitations of Autotest in catching bugs like this. Please take a look. https://docs.google.com/document/d/1LPpVx3RxKQ2zln-AgXfMxO78WxLZT65I16I309D3yGA/edit#
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/246bbef23e889d50609132a6b74e973a35ebc63d commit 246bbef23e889d50609132a6b74e973a35ebc63d Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Thu Dec 20 01:11:29 2018 Fix network configuration UI. Change CrOnc.getActiveProperties by allowing properties to have only "UserEditable" or "DeviceEditable" fields. Bug: 915957 Change-Id: I4dfeb3f2847d3e5318fcbef4e3f8b5ca691859a8 Reviewed-on: https://chromium-review.googlesource.com/c/1384373 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#618056} [modify] https://crrev.com/246bbef23e889d50609132a6b74e973a35ebc63d/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js
,
Dec 20
The bug is fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1384373
,
Dec 20
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. The owner of this bug should confirm if a merge is required here. If so, add Merge-Request-72 label and indicate which commits/CLs are to be merged. Otherwise, remove Merge-TBD label. Thanks.
,
Dec 20
,
Dec 20
aashutoshk@ Please verify that the bug was fixed.
,
Dec 21
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 26
aashutoshk@ - Re comment #25, can you verify that the bug is fixed?
,
Dec 26
@ dgagnon/nikitapodguzov: It looks like the fix is still not baked into the latest builds(11316.46.0). If this is incorrect can you please provide the build number to be tested?
,
Jan 2
The CL landed in 73.0.3646.0 (20th December), but looking at https://cros-goldeneye.corp.google.com/chromeos/console/listChromePfqBuild#/ it looks like the latest chrome builds all fail and there hasn't been an uprev in chrome versions since 18th of December (73.0.3644.0). I guess we'll just have to wait a little longer or you download a custom pre-flight image for you board (https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/eve-chrome-pfq/R73-11438.0.0-rc2 for eve, for example).
,
Jan 3
I can open configuration panel for VPN networks, but I see a couple of other issues 1) Configure button for policy pushed networks is grayed out and not clickable. 2) Cannot add VPN manually for enterprise user as "server hostname" field and "provider type" dropdown in the configuration panel are grayed out. 3) Only after making changes in the configuration panel, I can click connect; otherwise, the button is not highlighted. Tested on Robo360 (Coral) 11512.0.0 73.0.3654.0. feedback report: https://listnr.corp.google.com/report/85883627234
,
Jan 3
If this is a true beta-blocker, we have a problem. Everyone up to director level is OOO this week and we're making a beta candidate from the dev channel tomorrow.
,
Jan 3
@comment #30: (1) is actually a feature recently introduced ( bug 877424 ). You can only edit/configure policy pushed networks if they have 'recommended' (i.e. changeable by user) values. If all values are enforced, the 'Configure' button will be disabled. (2) can't reproduce that on ToT or M72 (3) AFAIK the connect button should only be clickable once the network is connectable (i.e. fully configured). @comment #31: atwilson@ is OOO until monday as well. @all: As of yesterday go/goldeneye lists images with chrome versions including the fix CL (>73.0.3646.0) from comment #21, so you should be able to test this now.
,
Jan 3
Please merge this change to M72 as soon as you can today and test it on the branch.
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c52524dd8e65459296a1b423ea205dc472d728ae commit c52524dd8e65459296a1b423ea205dc472d728ae Author: Alexander Hendrich <hendrich@chromium.org> Date: Thu Jan 03 22:13:15 2019 [Merge M72] Fix network configuration UI. Change CrOnc.getActiveProperties by allowing properties to have only "UserEditable" or "DeviceEditable" fields. (cherry picked from commit 246bbef23e889d50609132a6b74e973a35ebc63d) Bug: 915957 Change-Id: I4dfeb3f2847d3e5318fcbef4e3f8b5ca691859a8 Reviewed-on: https://chromium-review.googlesource.com/c/1384373 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Original-Commit-Position: refs/heads/master@{#618056} Reviewed-on: https://chromium-review.googlesource.com/c/1395023 Reviewed-by: David McMahon <djmm@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#555} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/c52524dd8e65459296a1b423ea205dc472d728ae/chromeos/services/assistant/BUILD.gn [modify] https://crrev.com/c52524dd8e65459296a1b423ea205dc472d728ae/ui/webui/resources/cr_elements/chromeos/network/cr_onc_types.js
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c52524dd8e65459296a1b423ea205dc472d728ae Commit: c52524dd8e65459296a1b423ea205dc472d728ae Author: hendrich@chromium.org Commiter: hendrich@chromium.org Date: 2019-01-03 22:13:15 +0000 UTC [Merge M72] Fix network configuration UI. Change CrOnc.getActiveProperties by allowing properties to have only "UserEditable" or "DeviceEditable" fields. (cherry picked from commit 246bbef23e889d50609132a6b74e973a35ebc63d) Bug: 915957 Change-Id: I4dfeb3f2847d3e5318fcbef4e3f8b5ca691859a8 Reviewed-on: https://chromium-review.googlesource.com/c/1384373 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Original-Commit-Position: refs/heads/master@{#618056} Reviewed-on: https://chromium-review.googlesource.com/c/1395023 Reviewed-by: David McMahon <djmm@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#555} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 3
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision c52524dd8e65459296a1b423ea205dc472d728ae was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Jan 3
Closing this as fixed. 2) Cannot add VPN manually for enterprise user as "server hostname" field and "provider type" dropdown in the configuration panel are grayed out. >>> I cannot reproduce the issue either, will open a separate issue to track it if I see it again.
,
Jan 7
as per the comment#37 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aashuto...@chromium.org
, Dec 18Status: Assigned (was: Untriaged)