New issue
Advanced search Search tips

Issue 915955 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task
q4



Sign in to add a comment

Create Web Navigation Utilities for methods depending on webstate

Project Member Reported by mrefaat@google.com, Dec 18

Issue description

Create a utilities file that contain logic that is executed based on the webState.
previously used to live on Tab.

example methods:
GoBack & GoForward
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84fc8828939c77deb9a75710040438e84a58c8aa

commit 84fc8828939c77deb9a75710040438e84a58c8aa
Author: mrefaat <mrefaat@chromium.org>
Date: Thu Dec 20 18:47:00 2018

Create web_navigation_util and use it for navigation logic that depend
on the webState.

Change SideSwipeController & BrowserViewController to use it instead of
tab methods.

Also Remove the existing tab_util and move the CreateWebLoadParams to
the navigation utils.

Bug:  899598 , 899423, 915955
Change-Id: I811e358fbd669c278855bf79f718274cc8cac712
Reviewed-on: https://chromium-review.googlesource.com/c/1380559
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618279}
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/tabs/BUILD.gn
[delete] https://crrev.com/c33c286e565fc89faaa492178a3b4ba7cf666ae8/ios/chrome/browser/tabs/tab_util.h
[delete] https://crrev.com/c33c286e565fc89faaa492178a3b4ba7cf666ae8/ios/chrome/browser/tabs/tab_util_unittest.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/BUILD.gn
[add] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util.h
[rename] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util.mm
[add] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util_unittest.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/web/public/test/fakes/test_navigation_manager.mm

Sign in to add a comment