Generic traces fail to open in DevTools |
|||||||||
Issue description
Generic traces fail to open in DevTools.
Uncaught TypeError: Cannot read property 'frameId' of null
at TimelineModel.TimelineModel.isMarkerEvent (TimelineModel.js:100)
at TimelineModel.TimelineModel._processEvent (TimelineModel.js:689)
at TimelineModel.TimelineModel._processThreadEvents (TimelineModel.js:530)
at TimelineModel.TimelineModel._processGenericTrace (TimelineModel.js:188)
at TimelineModel.TimelineModel.setEvents (TimelineModel.js:171)
at Timeline.PerformanceModel.setTracingModel (PerformanceModel.js:80)
at Timeline.TimelinePanel.loadingComplete (TimelinePanel.js:724)
at Timeline.TimelineLoader._finalizeTrace (TimelineLoader.js:214)
at setTimeout (TimelineLoader.js:205)
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4d558b19e3c79baa0442bddedc4a1114ae80013 commit b4d558b19e3c79baa0442bddedc4a1114ae80013 Author: Alexei Filippov <alph@chromium.org> Date: Tue Dec 18 02:26:09 2018 DevTools: Fix opening generic traces on performance panel. BUG= 915951 Change-Id: I0305e48ff4b155778b96e2d10caca3f9a545bccf Reviewed-on: https://chromium-review.googlesource.com/c/1381373 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#617350} [modify] https://crrev.com/b4d558b19e3c79baa0442bddedc4a1114ae80013/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js
,
Dec 18
,
Dec 18
,
Dec 18
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 19
Approving for M72 branch:3626
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f7c528c37003c53a5dbe553246ce25df4bfe94f commit 3f7c528c37003c53a5dbe553246ce25df4bfe94f Author: Alexei Filippov <alph@chromium.org> Date: Wed Dec 19 20:47:30 2018 DevTools: Fix opening generic traces on performance panel. BUG= 915951 TBR=alph@chromium.org (cherry picked from commit b4d558b19e3c79baa0442bddedc4a1114ae80013) Change-Id: I0305e48ff4b155778b96e2d10caca3f9a545bccf Reviewed-on: https://chromium-review.googlesource.com/c/1381373 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617350} Reviewed-on: https://chromium-review.googlesource.com/c/1384993 Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#472} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/3f7c528c37003c53a5dbe553246ce25df4bfe94f/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 3f7c528c37003c53a5dbe553246ce25df4bfe94f was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f7c528c37003c53a5dbe553246ce25df4bfe94f Commit: 3f7c528c37003c53a5dbe553246ce25df4bfe94f Author: alph@chromium.org Commiter: alph@chromium.org Date: 2018-12-19 20:47:30 +0000 UTC DevTools: Fix opening generic traces on performance panel. BUG= 915951 TBR=alph@chromium.org (cherry picked from commit b4d558b19e3c79baa0442bddedc4a1114ae80013) Change-Id: I0305e48ff4b155778b96e2d10caca3f9a545bccf Reviewed-on: https://chromium-review.googlesource.com/c/1381373 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617350} Reviewed-on: https://chromium-review.googlesource.com/c/1384993 Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#472} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 19
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by alph@chromium.org
, Dec 18