New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 915932 link

Starred by 2 users
Status: Untriaged
Owner:
█ steinbock@google.com
Last visit > 30 days ago
Cc:
█ steinbock@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Fix and re-enable CastAudioManagerTest.CanMakeStreamProxy

Project Member Reported by steinbock@google.com, Dec 17 
The test is broken due to synchronizing CastAudioOutputStream.Stop with its worker thread for 910449.
AudioManager.MakeAudioOutputStreamProxy() is not unregistering the output stream in this test, likely due to thread contention.
AudioManager.MakeAudioOutputStream() does not exhibit this issue.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2edecb8a8510b62d930c7ca8759e9acd40639cb

commit d2edecb8a8510b62d930c7ca8759e9acd40639cb
Author: Nate Steinbock <steinbock@google.com>
Date: Mon Dec 17 23:57:26 2018

Disable CastAudioManagerTest.CanMakeStreamProxy.

Streams created via MakeAudioOutputStreamProxy are not correctly unregistering from CastAudioManager in unit tests after the audio thread synchronization fix in chromium-review/1351718.

Bug: 915932
Change-Id: Ib0762d826db68682fc020300898dcd0f5d2bc2fe
Reviewed-on: https://chromium-review.googlesource.com/c/1378652
Commit-Queue: Nate Steinbock <steinbock@google.com>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617298}
[modify] https://crrev.com/d2edecb8a8510b62d930c7ca8759e9acd40639cb/chromecast/media/audio/cast_audio_manager_unittest.cc
►

Sign in to add a comment