Input handling in single threaded mode should use InputHandlerProxy |
|
Issue descriptionSee https://docs.google.com/document/d/1BX8V3ciUs8fV-x8dBI6rdz5_2dAmewgrUxIcWILXvGA/edit#heading=h.xqucj3afqd2g for details. Today, when input arrives in the renderer while in single threaded mode (i.e. LayoutTests) the events are routed directly into Blink. This entirely circumvents InputHandlerProxy and the various queues, coalescing, and routing logic that's used in production. To test the real-world logic, we've introduced several virtual/threaded test suites that run with --enable-threaded-compositing. However, the threaded tests are flaky and threaded test suites in layout tests are generally discouraged. This bug tracks making the renderer use the same code path for input handling regardless of whether a real compositor thread exists. We can then remove the virtual/threaded suites used for input code coverage.
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d78600aa460d1edafd70ef29c0c3a09d2f9cb156 commit d78600aa460d1edafd70ef29c0c3a09d2f9cb156 Author: David Bokan <bokan@chromium.org> Date: Tue Dec 18 20:52:18 2018 Update middleClickAutoscroll-click-hyperlink test Updates this test to use input injected in the browser process. Bug: 915926 Change-Id: I4a74e08bc9ee5b1a614c9d9a23b134bcfef0139c Reviewed-on: https://chromium-review.googlesource.com/c/1382859 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#617611} [delete] https://crrev.com/bfdf736d96bc620d4810aa3e2d1a369bbbe09fae/third_party/blink/web_tests/fast/events/middleClickAutoscroll-click-hyperlink-expected.txt [modify] https://crrev.com/d78600aa460d1edafd70ef29c0c3a09d2f9cb156/third_party/blink/web_tests/fast/events/middleClickAutoscroll-click-hyperlink.html |
|
►
Sign in to add a comment |
|
Comment 1 by bokan@chromium.org
, Dec 17