https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/11559 * Failed: 284 (281 expected, >>>3 unexpected<<<) Unexpected Failures: * http/tests/security/inactive-document-with-empty-security-origin.html * virtual/outofblink-cors-ns/http/tests/security/inactive-document-with-empty-security-origin.html * virtual/outofblink-cors/http/tests/security/inactive-document-with-empty-security-origin.html
I am going to mark the test as Timeout
More examples: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/43905 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7415
japhet: Does r617198 have anything to do with this? Just checking as that is one of the few Blink CLs in the blame list.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60c5601da44b213ff7110b26f74edde9216a2cdb commit 60c5601da44b213ff7110b26f74edde9216a2cdb Author: Luna Lu <loonybear@chromium.org> Date: Mon Dec 17 22:52:05 2018 mark http/tests/security/inactive-document-with-empty-security-origin.html as timeout Bug: 915903 Change-Id: I9338ee2f342a88843c3fc771531266c82160c002 Reviewed-on: https://chromium-review.googlesource.com/c/1381156 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#617272} [modify] https://crrev.com/60c5601da44b213ff7110b26f74edde9216a2cdb/third_party/blink/web_tests/TestExpectations
oh, I will mark them timeout on other bots too then
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c597a2d18650a11a677e5b723c34036928b81a2c commit c597a2d18650a11a677e5b723c34036928b81a2c Author: Luna Lu <loonybear@chromium.org> Date: Mon Dec 17 22:57:56 2018 mark http/tests/security/inactive-document-with-empty-security-origin.html timeout on other bots Bug: 915903 Change-Id: If63f32774646f65bcf58382c25160a4160f25720 Reviewed-on: https://chromium-review.googlesource.com/c/1380808 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#617273} [modify] https://crrev.com/c597a2d18650a11a677e5b723c34036928b81a2c/third_party/blink/web_tests/TestExpectations
cc mkwst@, as mkwst touched the test file last.
Issue 915938 has been merged into this issue.
Findit identified the culprit r617198 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEwZjNkNTVhZmU0ZTdlMGMxMDVhYTEyZjAzMGJjMDEwZDBlNjlhMAw Please revert the culprit, or disable the test(s) and find the appropriate owner to fix or delete. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r617198&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEwZjNkNTVhZmU0ZTdlMGMxMDVhYTEyZjAzMGJjMDEwZDBlNjlhMAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Likely mine, though I'm a little surprised it caused flakiness rather than outright failures...
It's consistent on this bot at least: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76501 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76502 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76503 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76504 has r617273 so it should go green.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8abe375b7913bdbccf9a21180f5dce93ad2dd8f3 commit 8abe375b7913bdbccf9a21180f5dce93ad2dd8f3 Author: Nate Chapin <japhet@chromium.org> Date: Tue Dec 18 08:16:54 2018 De-flake http/tests/security/inactive-document-with-empty-security-origin.html As of https://crrev.com/617198, about:blank navigation commit is asynchronous. This means that this test's main logic is often running before about:blank committed. Even a small delay should be enough to ensure the right timer ordering, so increase setTimeout to 10ms. Bug: 915903 Change-Id: I53d27b1e508059e315742023ddcb87e63d7341a0 Reviewed-on: https://chromium-review.googlesource.com/c/1381431 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#617409} [modify] https://crrev.com/8abe375b7913bdbccf9a21180f5dce93ad2dd8f3/third_party/blink/web_tests/TestExpectations [modify] https://crrev.com/8abe375b7913bdbccf9a21180f5dce93ad2dd8f3/third_party/blink/web_tests/http/tests/security/inactive-document-with-empty-security-origin.html
Last few bot runs look good. Feel free to reopen if flakiness reappears.
Comment 1 by loonyb...@chromium.org
, Dec 17