Issue metadata
Sign in to add a comment
|
[grunt] graphics_WebGLAquarium fails with Unhandled KeyError: 'value' |
||||||||||||||||||||||||
Issue descriptionLast good: R73-11395.0.0 First bad: R73-11396.0.0 https://crosland.corp.google.com/log/11395.0.0..11396.0.0 https://chromium.googlesource.com/chromium/src/+log/73.0.3638.0..73.0.3639.0?n=10000 https://stainless.corp.google.com/search?test=graphics_WebGLAquarium&col=build&view=matrix&row=model&first_date=2018-12-04&last_date=2018-12-17 12/14 13:34:41.909 WARNI| test:0606| The test failed with the following exception [...] return fn(instance, *d_args, **d_kwargs) File "/usr/local/autotest/tests/graphics_WebGLAquarium/graphics_WebGLAquarium.py", line 485, in run_once self.run_fish_test(cr.browser, test_url, n) File "/usr/local/autotest/tests/graphics_WebGLAquarium/graphics_WebGLAquarium.py", line 155, in run_fish_test avg_fps = tab.EvaluateJavaScript('g_crosFpsCounter.getAvgFps();') File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 221, in EvaluateJavaScript return self._inspector_backend.EvaluateJavaScript(*args, **kwargs) File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 263, in EvaluateJavaScript user_gesture=user_gesture) File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 38, in Inner return func(inspector_backend, *args, **kwargs) File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 547, in _EvaluateJavaScript user_gesture) File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 58, in Evaluate return res['result']['result']['value'] KeyError: 'value'
,
Dec 17
,
Dec 18
catapult was rolled forward as a part of the Chrome uprev, which looks suspicious: https://chromium.googlesource.com/chromium/src/+/ec63c2993d51dc2df2d6604fd33131fcbe65889b
,
Dec 18
Reverting that change (+gclient sync) didn't seem to fix anything. Still investigating.
,
Dec 20
Looks like this commit is the culprit: https://chromium-review.googlesource.com/c/chromium/src/+/1348974 This change broke WebGL on Chrome OS in general.
,
Dec 20
Yes, the change is in the regression range. A bit strange that the test indicated failures only on AMD. https://chromium.googlesource.com/chromium/src/+/bce53252ce5ded76582c9a27a499bda2249052fc
,
Dec 20
To be clear, I bisected Chrome in that range and identified that commit as the culprit. When looking at the commit in Gerrit, that lead me to the reverts that were already in progress and the generic WebGL issue.
,
Dec 20
I agree. Thanks! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ihf@chromium.org
, Dec 17Components: OS>Kernel>Graphics
Labels: Gfx-Guard