New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 915856 link

Starred by 2 users
Status: Verified
Owner:
liaoyuke@chromium.org
Closed: Jan 9
Cc:
█ robert...@chromium.org
liaoyuke@chromium.org
mmoroz@chromium.org
infe...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 915811



Sign in to add a comment

Wrong data is shown when switch between patchsets

Project Member Reported by liaoyuke@chromium.org, Dec 17 
Steps to repro:
1. https://chromium-review.googlesource.com/c/chromium/src/+/1369647
2. Expand the diff view to see uncovered lines.
3. Go to patchset #3.
4. Expand the diff view to see uncovered lines.
5. Go back to patchset $4.
6. Expand the diff view to see uncovered lines.

The uncovered lines is marked on wrong line numbers.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/code-coverage/+/74648767e801782fc8d357fb5c20eab3771c206f

commit 74648767e801782fc8d357fb5c20eab3771c206f
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jan 03 20:56:14 2019

[code coverage] Clean up legacy buggy code

The removed code was added to work handle the issue when user switches
between changes or patchsets, now that the issue is handled by the
"showchange" callback more gracefully, the work around is not needed
anymore, and what's more, due to that the same issue is unnecessarily
handled twice, they cause a bug where annotations may disapear
unexpectedly when switching between patchsets.

This CL fixes the issue by removing the unnecessary workaround.

Bug:  915856 
Change-Id: I29ee76f4b6e3588f6cb5251b209f4eb53c126793
[modify] https://crrev.com/74648767e801782fc8d357fb5c20eab3771c206f/src/main/resources/static/chromium-coverage.html

Comment 2 by liaoyuke@chromium.org, Jan 9

Status: Verified (was: Assigned)
►

Sign in to add a comment