New issue
Advanced search Search tips

Issue 915833 link

Starred by 1 user
Status: Fixed
Owner:
minch@chromium.org
Closed: Dec 18
Cc:
omrilio@chromium.org
x...@chromium.org
mccanny@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Home launcher can't be swiped up from auto-hide shelf when multiple windows are opened

Project Member Reported by minch@chromium.org, Dec 17 
Chrome Version: 73.0.3641.0

What steps will reproduce the problem?
(1) In tablet mode, set shelf to auto-hide.
(2) Open more than one window.
(3) Swipe up from the bottom to show the auto-hide shelf.
(4) Swipe up on the auto-hide shown shelf.

What is the expected result?
Auto-hide shelf changes to hidden.

What happens instead?
Keep auto-hide shelf shown and drag up the home launcher.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddacdceff49bbc94e703f270a6751e03db8b0a79

commit ddacdceff49bbc94e703f270a6751e03db8b0a79
Author: Min Chen <minch@google.com>
Date: Tue Dec 18 21:06:26 2018

shelf: Drag home launcher from auto-hide shelf.

SetUpWindows in HomeLauncherGestureHandler::OnPressEvent could cause
window stacking change when more than one window are opened. This might
hide the auto-hide shelf when start drag the home launcher from it,
which means the following gesture events won't be dispatched to the
shelf then to HomeLancherGestureHandler to continue the drag.
This cl fixed the issue by making sure the auto-hide shelf is visible
once start dragging the home launcher from it.

Bug:  915833 
Change-Id: Ib47cacd12656ca43dfa006edec19b164ac2f4b88
Reviewed-on: https://chromium-review.googlesource.com/c/1380594
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617617}
[modify] https://crrev.com/ddacdceff49bbc94e703f270a6751e03db8b0a79/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/ddacdceff49bbc94e703f270a6751e03db8b0a79/ash/shelf/shelf_layout_manager_unittest.cc

Comment 2 by minch@chromium.org, Dec 18

Status: Fixed (was: Started)
►

Sign in to add a comment