sqlite: disable `sqlite` program |
||||||||||||
Issue descriptionwe have no need for the `sqlite` program afaik. any package that uses it does so through the library interface. so lets disable the program until someone actually cares about it. we can do so by creating a chromiumos-overlay/chromeos/config/env/dev-db/sqlite file with content like chromiumos-overlay/chromeos/config/env/sys-apps/util-linux where we mask out the /usr/bin/sqlite* programs.
,
Dec 17
,
Dec 18
Looks like there wasn't a CL for this yet, so here is one: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1382920 Let's see how it fares on the trybots.
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0370ec7b1a8a1969bc20469025b931bec0d1c3d0 commit 0370ec7b1a8a1969bc20469025b931bec0d1c3d0 Author: Mattias Nissler <mnissler@chromium.org> Date: Thu Dec 20 21:50:00 2018 dev-db/sqlite: Don't install /usr/bin/sqlite3 We apparently don't need it anyways, so free up a bit of space. BUG= chromium:915827 TEST=Image builds and passes tests. Change-Id: I8e713f09bfac3ff3780a93b5ee15d849e408322e Reviewed-on: https://chromium-review.googlesource.com/1382920 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/0370ec7b1a8a1969bc20469025b931bec0d1c3d0/chromeos/config/env/dev-db/sqlite
,
Dec 21
Can this be marked fixed?
,
Jan 2
Mattias, has the CL stuck? I want to mark this as Fixed if so so I can bubble that up to the main exploit.
,
Jan 7
Yes, this is fixed.
,
Jan 8
Bumping to P-1 since this is critical to breaking the chain, and requesting a merge to 72.
,
Jan 8
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 10
Flipping back to fixed (which I believe is a prerequisite for this to be considered for merging).
,
Jan 15
What's the status of this merge review?
,
Jan 15
Without M-72, this will not appear on the usual queries.
,
Jan 15
,
Jan 16
(6 days ago)
Merged to M72 per https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1416250
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/308b17934455aee0dac3d8968f0f6fb2ce72deac commit 308b17934455aee0dac3d8968f0f6fb2ce72deac Author: Mattias Nissler <mnissler@chromium.org> Date: Wed Jan 16 20:39:12 2019 dev-db/sqlite: Don't install /usr/bin/sqlite3 We apparently don't need it anyways, so free up a bit of space. BUG= chromium:915827 TEST=Image builds and passes tests. Change-Id: I8e713f09bfac3ff3780a93b5ee15d849e408322e Reviewed-on: https://chromium-review.googlesource.com/1382920 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 0370ec7b1a8a1969bc20469025b931bec0d1c3d0) Reviewed-on: https://chromium-review.googlesource.com/c/1416250 Reviewed-by: Mattias Nissler <mnissler@chromium.org> [add] https://crrev.com/308b17934455aee0dac3d8968f0f6fb2ce72deac/chromeos/config/env/dev-db/sqlite |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 Deleted