New issue
Advanced search Search tips

Issue 915814 link

Starred by 2 users
Status: Assigned
Owner:
dbertoni@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Task Queue Unification Refactoring

Project Member Reported by dbertoni@chromium.org, Dec 17 
Feature description: This work will help bring the Background Page and Service Worker task queues together.

Eng owner: dbertoni

Are you planning on experimenting before launch? no
Any new strings? no
Any implications for Google webservices (i.e. sync, translate)? none
Binary size? Reduced
Do the existing perf tests exercise all aspects of your new feature(s)? yes
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8269a093f20adb3283259f9de27dc76e6d40cf25

commit 8269a093f20adb3283259f9de27dc76e6d40cf25
Author: David Bertoni <dbertoni@chromium.org>
Date: Wed Dec 19 15:55:42 2018

[Extensions] Merge AddPendingTaskToDispatchEvent with AddPendingTask.

This CL integrates previous refactoring changes to have a single add task API for the task queues.

Bug: 915814
Change-Id: I1098d0785df50c025bff6c74bc28515d86b88ed8
Reviewed-on: https://chromium-review.googlesource.com/c/1380822
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617843}
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/apps/launcher.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/chrome/browser/extensions/devtools_util.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/api/messaging/message_service.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/api/runtime/runtime_api.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/events/lazy_event_dispatcher.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/extension_registrar.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/guest_view/app_view/app_view_guest.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/lazy_background_task_queue.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/lazy_background_task_queue.h
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/lazy_background_task_queue_unittest.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/lazy_context_task_queue.h
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/process_manager.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/service_worker_task_queue.cc
[modify] https://crrev.com/8269a093f20adb3283259f9de27dc76e6d40cf25/extensions/browser/service_worker_task_queue.h
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64786436b5081b567a7f0e2b9f39cb4d32e89d85

commit 64786436b5081b567a7f0e2b9f39cb4d32e89d85
Author: David Bertoni <dbertoni@chromium.org>
Date: Fri Dec 21 23:10:12 2018

[Extensions] Use LazyContextId in maps instead of std::pair.

We use std::pair as both a key and a value in some maps. Using LazyContextId makes the code more readable and a bit more efficient in some places.

Bug: 915814
Change-Id: I9026bff13d74e093b6d703b7d4d95d07fe33e3c6
Reviewed-on: https://chromium-review.googlesource.com/c/1384751
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618657}
[modify] https://crrev.com/64786436b5081b567a7f0e2b9f39cb4d32e89d85/extensions/browser/api/messaging/message_service.cc
[modify] https://crrev.com/64786436b5081b567a7f0e2b9f39cb4d32e89d85/extensions/browser/api/messaging/message_service.h
[modify] https://crrev.com/64786436b5081b567a7f0e2b9f39cb4d32e89d85/extensions/browser/lazy_background_task_queue.cc
[modify] https://crrev.com/64786436b5081b567a7f0e2b9f39cb4d32e89d85/extensions/browser/lazy_background_task_queue.h
[modify] https://crrev.com/64786436b5081b567a7f0e2b9f39cb4d32e89d85/extensions/browser/lazy_context_id.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/100d46dafcda5486de4c81922e3222e054467786

commit 100d46dafcda5486de4c81922e3222e054467786
Author: David Bertoni <dbertoni@chromium.org>
Date: Fri Jan 04 01:03:06 2019

[Extensions] Refactor LazyEventDispatcher to be agnostic as to task type.


LazyEventDispatcher no longer distinguishes between background page and service worker tasks.

Bug: 915814
Change-Id: I9346b1d97c7df7080dbac67e28cbb7ceaa919b06
Reviewed-on: https://chromium-review.googlesource.com/c/1391475
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619839}
[modify] https://crrev.com/100d46dafcda5486de4c81922e3222e054467786/extensions/browser/event_router.cc
[modify] https://crrev.com/100d46dafcda5486de4c81922e3222e054467786/extensions/browser/events/lazy_event_dispatcher.cc
[modify] https://crrev.com/100d46dafcda5486de4c81922e3222e054467786/extensions/browser/events/lazy_event_dispatcher.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/641e3ce0cd54b64d5eea457f22e98352f9ee09c8

commit 641e3ce0cd54b64d5eea457f22e98352f9ee09c8
Author: David Bertoni <dbertoni@chromium.org>
Date: Fri Jan 11 20:35:12 2019

[Extensions] Remove most references to LazyBackgroundTaskQueue.

This CL is part of the effort to unify the LazyBackgroundTaskQueue and the ServiceWorkerTaskQueue.

Bug: 915814
TBR: dmazzoni@chromium.org (Removed a header file in accessibility_extension_api.cc)
Change-Id: I067bc70b4ed047a0466d70b7d976e01806e7bf98
Reviewed-on: https://chromium-review.googlesource.com/c/1404577
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Anand Mistry <amistry@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622127}
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/apps/launcher.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/chrome/browser/accessibility/accessibility_extension_api.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/chrome/browser/extensions/devtools_util.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/chromecast/browser/extensions/cast_extension_system.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/extensions/browser/api/messaging/message_service.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/extensions/browser/api/messaging/message_service.h
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/extensions/browser/api/runtime/runtime_api.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/extensions/browser/events/lazy_event_dispatcher.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/extensions/browser/extension_registrar.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/extensions/browser/guest_view/app_view/app_view_guest.cc
[modify] https://crrev.com/641e3ce0cd54b64d5eea457f22e98352f9ee09c8/extensions/browser/process_manager.cc
►

Sign in to add a comment