Empty theme changes the colour of Incognito toolbar and frame
Reported by
jeremyfa...@outlook.com,
Dec 17
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36 Steps to reproduce the problem: 1. Observe that when Chrome is not using any theme, the Incognito window has a dark-grey active tab and toolbar, and a very-dark-grey frame (title bar). See "screenshot-1" attached. 2. Create and apply a Chrome theme without any colour values at all in the theme, ie. an empty theme. See attached "Empty Theme.zip". 3. Open Incognito window. 4. Observe that the Incognito window's active tab & toolbar are now white, instead of dark-grey - ie. they use the same colour as the normal window's active tab & toolbar, even though the theme did not define any colours. See screenshot-2. 5. In addition, the Incognito window's frame colour is now medium-grey rather than very-dark-grey. See screenshot-2. What is the expected behavior? What went wrong? Expected: Using an "empty" theme - with no defined colours - should (by resonable expectation) result in all default colours being used, including in the Incognito window. Instead, an empty theme currently changes the Incognito window's active tab and toolbar to white, and its frame to light-grey. If no frame or toolbar colour is set in the theme, then the Incognito window's frame and toolbar should use the default Incognito colours. Did this work before? N/A Chrome version: 71.0.3578.98 Channel: stable OS Version: 10.0 Flash Version:
,
Dec 18
jeremyfairbrass@ Thanks for the issue. Able to reproduce this issue on Windows 10 on the latest Stable 71.0.3578.98 and latest Canary 73.0.3642.0. Unable to check the issue on Mac OS 10.13.6 and Ubuntu 17.10 as we are unable to extract the zip file and add to chrome. This is a Non-Regression issue as this behavior is observed from M-60 chrome builds. Attached is the screen shot for reference. Hence marking this as Untriaged for further updates from Dev. Thanks..
,
Dec 18
Thanks Susan. Small point of clarification: in your screenshot, you're using a test theme called "Test Theme with white active tab". Does that mean you've included and defined the "toolbar" value in your test theme? If so, that's a slightly different issue to what I'm reporting. My bug report here is for the scenario where the theme does *not* include or define the "toolbar" value, yet the Incognito window changes its toolbar colour anyway. (The "toolbar" value in the theme controls both the toolbar and the active tab). Can you confirm that you tested it on Chrome 60 with a truly empty theme? |
||
►
Sign in to add a comment |
||
Comment 1 by swarnasree.mukkala@chromium.org
, Dec 18