Issue metadata
Sign in to add a comment
|
Update text for Duet IPH |
||||||||||||||||||||
Issue descriptionThis issue is used to track updates to the IPH text for Duet. New Spec here: https://docs.google.com/document/d/1xeDaVuHrTHXYJJ6AdIa8K0LiapyZb4GKDIw4EZLOz9U/edit#heading=h.f8rwa7nrzjos
,
Dec 20
mdjones@ is OOO so I am asking for merge request to 72. I know it is late for a string change but my understanding is we have permission to do it. meggynwatkins@ is the UX Writer and can clarify if I am wrong. Also this change would would only impact the bottom toolbar experiment and is behind a flag so it is relatively safe.
,
Dec 20
This bug requires manual review: There is .grd file changes and we are only 39 days from stable. Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 20
Pls update bug with canary result tomorrow. Also pls note this is the last string change we will take it for M72 if change looks good in canary as it is way past Feature/String freeze (M72 Feature/String Freeze on 11/09 and Branch on 11/29). Also may I please know why we're getting multiple merge requests for Duet? +srahim@ to keep her in loop.
,
Dec 20
The NextAction date has arrived: 2018-12-20
,
Dec 20
Following strings are submitted for translation, pls check and confirm. https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=9181147714908018407 https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=3926039706714857374
,
Dec 20
Just checked Canary and everything looks good there. The linked strings also look good. We are currently running a Duet experiment in 71 and have some changes we'd like to see in the 72 experiment so that is why we are having late merges. Most of the merges have been fairly trivial so the likelihood of causing a breakage is low and even if a serious bug was introduced it would only impact the experiment which could be disabled. As for the late string changes we have approval from the text team. We would appreciate the late merge. Thanks!
,
Dec 20
Approving merge to M72 branch 3626 based on comment #7. Please merge ASAP. Thank you. Note: We won't be taking additional merges in unless extremely critical and fully safe.
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc63e519f6b9639b1548b62170d2c51c9d6e50c5 Commit: fc63e519f6b9639b1548b62170d2c51c9d6e50c5 Author: mdjones@chromium.org Commiter: amaralp@chromium.org Date: 2018-12-20 19:57:59 +0000 UTC Update strings for Duet IPH Bug: 915799 Change-Id: I2a6bb6a26f87f0adb891808530884f5dd363e3c9 Reviewed-on: https://chromium-review.googlesource.com/c/1380801 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618009}(cherry picked from commit b035b65c0a04833fa41cc91f0a66d571579ef335) Reviewed-on: https://chromium-review.googlesource.com/c/1387606 Cr-Commit-Position: refs/branch-heads/3626@{#488} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc63e519f6b9639b1548b62170d2c51c9d6e50c5 commit fc63e519f6b9639b1548b62170d2c51c9d6e50c5 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Dec 20 19:57:59 2018 Update strings for Duet IPH Bug: 915799 Change-Id: I2a6bb6a26f87f0adb891808530884f5dd363e3c9 Reviewed-on: https://chromium-review.googlesource.com/c/1380801 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618009}(cherry picked from commit b035b65c0a04833fa41cc91f0a66d571579ef335) Reviewed-on: https://chromium-review.googlesource.com/c/1387606 Cr-Commit-Position: refs/branch-heads/3626@{#488} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/fc63e519f6b9639b1548b62170d2c51c9d6e50c5/chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarMediator.java [modify] https://crrev.com/fc63e519f6b9639b1548b62170d2c51c9d6e50c5/chrome/android/java/strings/android_chrome_strings.grd
,
Jan 3
,
Jan 9
Re-tested same with M72-ChromeBeta-72.0.3626.53 build and not displayed IPH help text,when first time the app is started. Enabled below flags Chrome Duet In-Product Help Demo Mode -Enabled IPH_ChromeDuet
,
Jan 9
mdjones@, the entire IPH is not visible which is a problem predating the updated string CL. Do you know if both the initial /src and /clank IPH CL's made it into 72?
,
Jan 9
Requesting merge for chrome-internal patch. The internal patch appears to have just barely missed the M72 branch cut. All of the code has been extensively tested since the branch point (in M73+) and the code in question is guarded by the duet flag. The patch itself is a set of libraries that touch little outside of it's own directory, so merge should experience no conflict.
,
Jan 9
This bug requires manual review: There is .grd file changes and we are only 19 days from stable. Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 9
The internal bug for comment #15: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/720549
,
Jan 9
Approving merge to M72 branch 3626 based on comment #15, #17 and per offline chat with mdjones@. Please merge ASAP. Thank you.
,
Jan 9
The patch references a different bug; merged here: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/780910
,
Jan 9
Please verify this bug on 72.0.3626.54+. Thank you.
,
Jan 9
,
Jan 10
Verified in M72-72.0.3626.54/Pixel 2 Xl/9.0 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 19