Issue metadata
Sign in to add a comment
|
PreviewsLitePageServerBrowserTest.LitePagePreviewsReportSavings is flaky |
||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of lunalu@google.com Builders failed on: - linux-xenial-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel It failed on these 2 builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/5657 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/5659
,
Dec 17
,
Dec 17
,
Dec 17
[ RUN ] PreviewsLitePageServerBrowserTest.LitePagePreviewsReportSavings
...
../../chrome/browser/previews/previews_lite_page_browsertest.cc:1110: Failure
Expected equality of these values:
GetDataUsage()
Which is: 0
20U
Which is: 20
Also, "linux-xenial-rel" is not an Android bot.
,
Dec 17
The test already has a "DISABLE_ON_WIN_MAC" macro applied. :-\ If I don't hear back soon, I'm just going to disable the test on all platforms.
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ad18b28c0e07682133778ed1410c3f48d1bce4e commit 6ad18b28c0e07682133778ed1410c3f48d1bce4e Author: Lei Zhang <thestig@chromium.org> Date: Mon Dec 17 22:47:15 2018 Disable a flaky PreviewsLitePageServerBrowserTest. The LitePagePreviewsReportSavings test case is flaky on Linux. BUG= 915775 TBR=robertogden@chromium.org Change-Id: I48ea207d82a0463aa3e30a525f6140022a50a074 Reviewed-on: https://chromium-review.googlesource.com/c/1381137 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#617271} [modify] https://crrev.com/6ad18b28c0e07682133778ed1410c3f48d1bce4e/chrome/browser/previews/previews_lite_page_browsertest.cc
,
Dec 17
Test disabled. Removing from sheriff queue.
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0452174c2541be82695e17ae5fca0530ddabe2e8 commit 0452174c2541be82695e17ae5fca0530ddabe2e8 Author: Robert Ogden <robertogden@chromium.org> Date: Wed Jan 02 21:22:34 2019 Reenable LitePagePreviewsReportSavings test This test was flaky because the reported data savings was sometimes zero. I was unable to repro locally, but adding another navigation afterwards should help a lot and I'll keep tabs on it with FindIt. Bug: 915775 Change-Id: Ib55370ed3ccdd4e047acfe30ca342d9693a560bc Reviewed-on: https://chromium-review.googlesource.com/c/1392598 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#619496} [modify] https://crrev.com/0452174c2541be82695e17ae5fca0530ddabe2e8/chrome/browser/previews/previews_lite_page_browsertest.cc
,
Jan 2
Check https://findit-for-me.appspot.com/waterfall/list-flakes?test_name=PreviewsLitePageServerBrowserTest.LitePagePreviewsReportSavings tomorrow when the above patch has been on the waterfall awhile
,
Jan 3
The NextAction date has arrived: 2019-01-03
,
Jan 3
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by loonyb...@chromium.org
, Dec 17