per-cl coverage doesn't show uncovered lines correct when switch between files in diff view |
||
Issue descriptionTo repro: 1. Go to: https://chromium-review.googlesource.com/c/chromium/src/+/1369646 2. Click on: base/threading/thread.h 3. Click on 'Next' button to go to https://chromium-review.googlesource.com/c/chromium/src/+/1369646/1/base/threading/thread.cc. Expected behavior: Uncovered lines are highlighted correct. However, they're not. It's likely a corner case that the Gerrit plugin failed to handle.
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/code-coverage/+/0e0714b67d083a5cbba6516881d7b12725219645 commit 0e0714b67d083a5cbba6516881d7b12725219645 Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Jan 03 20:51:23 2019 [code coverage] Correctly handle diff between patchsets This CL makes the regular expression correct match the URL when the page is showing diff between two non-base patchsets. Bug: 915752 Change-Id: Ie770d46e7dc90c84ee4392b7a82a3ce71de84ebf [modify] https://crrev.com/0e0714b67d083a5cbba6516881d7b12725219645/src/main/resources/static/chromium-coverage.html
,
Jan 9
|
||
►
Sign in to add a comment |
||
Comment 1 by liaoyuke@chromium.org
, Dec 17