New issue
Advanced search Search tips

Issue 915739 link

Starred by 10 users

Issue metadata

Status: Duplicate
Merged: issue 915637
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Cookies not set for css map requests

Reported by pvo...@netflix.com, Dec 17

Issue description

UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce the problem:
Load a site that uses cookies with dev tools open. Requests for the css map file no longer show in the network tab, but server logs show the request being made. However the cookie is missing. All other requests contain the correct cookie.

What is the expected behavior?
The request for the css map file should contain the cookie.

What went wrong?
The request for the css map file did not contain the cookie.

Did this work before? Yes 69

Chrome version: 71.0.3578.98  Channel: stable
OS Version: kernel 4.15.0-42
Flash Version: 

It would also be nice if the map requests showed in the dev tools network tab again.
 
Labels: Needs-Feedback
Could you please provide more information -- having a site to reproduce that or at least screenshots of the requests would probably help.
Note that the expected behavior for cookies for cross-origin requests now is not to display raw cookies in DevTools (see  issue 793692  for details), but this does not affect whether cookies are actually sent.

Unfortunately I cannot give a site that reproduces as the sites I have seen this behavior on are not on the public internet. I can't confirm with any external sites as the map request doesn't show in devtools and the only proof I have that the map request was made is from server side logs.  

Without any map requests showing in devtools I'm not sure what I would take a screenshot of. Are css map requests showing up in the dev tools networking tab for you?

These were not cross domain requests, so I don't think  issue 793692  is related.

Project Member

Comment 3 by sheriffbot@chromium.org, Dec 17

Cc: caseq@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Triage-M71 Needs-Bisect
Labels: Triaged-ET
As per comment# 2 from reporter, it isn't possible to provide sample Test filer/URL that reproduces the issue, without sample file TE cannot proceed further on triaging the issue. Hence requesting someone from the Platform>Devtools team help in providing further inputs on this issue.

Thanks!
We face the same issue not only for css source maps but also for JS source maps. We see this issue on Linux and Windows. 

Chromium version:  71.0.3578.98 (Offizieller Build) Arch Linux (64-Bit)

I attached two screenshots of the source map request which I captured via mitmproxy. One with Chromium 71.0.3578.98 where the cookies are missing and the same request with Chromium 70.0.3538.77 which contains the cookies.

As this is an non public application my company is working on I cannot send you a real example you can test yourself.  

Please let me know if you need more information. 
source_map_req_wo_cookie_chromium_71.png
48.4 KB View Download
source_map_req_with_cookie_chromium_70.png
51.9 KB View Download
Cc: santhoshkumar@chromium.org
Labels: -Needs-Bisect
As per comment#2 updating comment #5 and removing Needs-Bisect label.
More details, it happens when `SameSite` is `lax`,and with chrome console opened in 71 .
This issue exists on MacOS as well.
Mergedinto: 915637
Owner: caseq@chromium.org
Status: Duplicate (was: Unconfirmed)
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0a9c2ed1e36b2d3cebe2845806a355ea470ec50

commit a0a9c2ed1e36b2d3cebe2845806a355ea470ec50
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Jan 08 03:50:59 2019

DevTools: fix SameSite cookies not sent after migration to SimpleURLLoader

Bug:  915637 , 915739 
Change-Id: I15eecfd7d3e8c992d0907b6499c57764ca538f09
Reviewed-on: https://chromium-review.googlesource.com/c/1399515
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620611}
[modify] https://crrev.com/a0a9c2ed1e36b2d3cebe2845806a355ea470ec50/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/a0a9c2ed1e36b2d3cebe2845806a355ea470ec50/content/shell/browser/shell_devtools_bindings.cc
[modify] https://crrev.com/a0a9c2ed1e36b2d3cebe2845806a355ea470ec50/third_party/blink/renderer/devtools/front_end/Tests.js

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 10

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cacdf46e76e875a484d8dbd6b3525f9fdd6f017

commit 0cacdf46e76e875a484d8dbd6b3525f9fdd6f017
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Jan 10 18:57:54 2019

DevTools: fix SameSite cookies not sent after migration to SimpleURLLoader

Bug:  915637 , 915739 
Change-Id: I15eecfd7d3e8c992d0907b6499c57764ca538f09
Reviewed-on: https://chromium-review.googlesource.com/c/1399515
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620611}(cherry picked from commit a0a9c2ed1e36b2d3cebe2845806a355ea470ec50)
Reviewed-on: https://chromium-review.googlesource.com/c/1405538
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#633}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/0cacdf46e76e875a484d8dbd6b3525f9fdd6f017/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/0cacdf46e76e875a484d8dbd6b3525f9fdd6f017/content/shell/browser/shell_devtools_bindings.cc
[modify] https://crrev.com/0cacdf46e76e875a484d8dbd6b3525f9fdd6f017/third_party/blink/renderer/devtools/front_end/Tests.js

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/0cacdf46e76e875a484d8dbd6b3525f9fdd6f017

Commit: 0cacdf46e76e875a484d8dbd6b3525f9fdd6f017
Author: caseq@chromium.org
Commiter: caseq@chromium.org
Date: 2019-01-10 18:57:54 +0000 UTC

DevTools: fix SameSite cookies not sent after migration to SimpleURLLoader

Bug:  915637 , 915739 
Change-Id: I15eecfd7d3e8c992d0907b6499c57764ca538f09
Reviewed-on: https://chromium-review.googlesource.com/c/1399515
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620611}(cherry picked from commit a0a9c2ed1e36b2d3cebe2845806a355ea470ec50)
Reviewed-on: https://chromium-review.googlesource.com/c/1405538
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#633}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment