Issue metadata
Sign in to add a comment
|
Navigation Predictor: Preconnect after onLoad does not happen in majority of cases |
||||||||||||||||||||
Issue descriptionIn some cases, at the time of onLoad, the navigation predictor may predict that a URL needs to be prefetched. In other cases, it may predict that an origin needs to be preconnected to. With "same_origin_preconnecting_allowed" param set, it will preconnect back to the main frame origin in only the second case (when the prediction was a preconnect prediction). However, even in the first case (when the prediction was a prefetch prediction), it is expected that NavigationPredictor make a preconnect attempt to the document origin.
,
Dec 18
,
Dec 19
,
Dec 20
The NextAction date has arrived: 2018-12-20
,
Dec 20
The CL in #1 went to Android 73.0.3644.0 which has been in canary for few days. Requesting merge approval for CL in #1. The CL is behind a finch, so it's safe to merge. The merge will help us in preconnecting more often which should lead to faster page loads.
,
Dec 20
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 20
Approving merge to M72 branch 3626 based on comment #5. Please merge ASAP. Thank you.
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97cf5da9223d449ce8df1dd755f65470efe55914 commit 97cf5da9223d449ce8df1dd755f65470efe55914 Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Dec 21 00:08:09 2018 NavigationPredictor: Preconnect to the main frame origin on onLoad Currently, when "same_origin_preconnecting_allowed" param is set, navigation predictor will preconnect to the origin of the main frame document if navigation predictor's recommendation was to preconnect. This CL makes changes to preconnect to the origin of the main frame document if navigation predictor's recommendation is to "prefetch". This is still guarded behind "same_origin_preconnecting_allowed" finch param. Change-Id: I6549eba66d5dd300a877c548b62f0a2dcb587616 Bug: 915718 Reviewed-on: https://chromium-review.googlesource.com/c/1379703 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617382}(cherry picked from commit b8814c105b14ce114c0b11be0d4b4c6a0425ba50) Reviewed-on: https://chromium-review.googlesource.com/c/1388169 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#493} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/97cf5da9223d449ce8df1dd755f65470efe55914/chrome/browser/navigation_predictor/navigation_predictor.cc [modify] https://crrev.com/97cf5da9223d449ce8df1dd755f65470efe55914/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97cf5da9223d449ce8df1dd755f65470efe55914 Commit: 97cf5da9223d449ce8df1dd755f65470efe55914 Author: tbansal@chromium.org Commiter: tbansal@chromium.org Date: 2018-12-21 00:08:09 +0000 UTC NavigationPredictor: Preconnect to the main frame origin on onLoad Currently, when "same_origin_preconnecting_allowed" param is set, navigation predictor will preconnect to the origin of the main frame document if navigation predictor's recommendation was to preconnect. This CL makes changes to preconnect to the origin of the main frame document if navigation predictor's recommendation is to "prefetch". This is still guarded behind "same_origin_preconnecting_allowed" finch param. Change-Id: I6549eba66d5dd300a877c548b62f0a2dcb587616 Bug: 915718 Reviewed-on: https://chromium-review.googlesource.com/c/1379703 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617382}(cherry picked from commit b8814c105b14ce114c0b11be0d4b4c6a0425ba50) Reviewed-on: https://chromium-review.googlesource.com/c/1388169 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#493} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 21
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 18