New issue
Advanced search Search tips

Issue 915708 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

underscore not rendered in scope pane

Reported by davidmax...@gmail.com, Dec 17

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3639.1 Safari/537.36

Steps to reproduce the problem:
1. open https://jsbin.com/ganinut in browser
2. open dev tools
3. reload

What is the expected behavior?
it should render the '_' characters in the values of variables

What went wrong?
Underscores ('_') look just like spaces (' ')

Did this work before? N/A 

Chrome version: 73.0.3639.1  Channel: dev
OS Version: 
Flash Version: 

note that underscores are rendered ok in the 'watch' pane (type 'someValue' in there)
image attached of my actual app, but same on the jsbin example
 
missing_underscore.png
14.1 KB View Download
Labels: Needs-Triage-M73
Cc: viswa.karala@chromium.org
Labels: Triaged-ET Needs-Feedback
Tried testing the issue on chrome reported version# 73.0.3639.1 using Ubuntu 14.04 with steps mentioned below:
1) Launched chrome reported version and navigated to URL: https://jsbin.com/ganinut
2) Page got loaded successfully, opened Devtools and clicked on reload the page
3) Under watch, didn't seen entry and page didn't get loaded completely

@Reporter: Please find the attached screencast for your reference and let us know if we missed anything in reproducing the issue, provide your feedback on it which help in further triaging it in better way.

Thanks!
915708.ogv
1.4 MB View Download
Nope, you didn't miss anything - except that the problem isn't with 'watch' (you have to manually add it yourself (I can't do that from here) - is it with the 'scope/local'.
It looks like it is working for you, but it isn't for me.

This is the chrome://version for me, which looks like the same as you have:

Google Chrome	73.0.3639.1 (Official Build) dev (64-bit)
Revision	5c6469ade1252bc3636320e8865710cb1bafa4ce-refs/branch-heads/3639@{#6}
OS	Linux
JavaScript	V8 7.3.117
Flash	32.0.0.105 /home/davidmaxwaterman/.config/google-chrome-unstable/PepperFlash/32.0.0.105/libpepflashplayer.so
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 

I see you tried it on ubuntu 14.04, while I am using:

$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.1 LTS"

Perhaps it is something related to that.

I could do a screencast too (if you tell me how you do that), but I think the screen snapshot shows I'm not lying :)

I'll do another one of the jsbin...
missing_underscore-jsbin.png
149 KB View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 18

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
davidmaxwaterman@ Thanks for your feedback!

As mentioned in comment# 3, could you please provide any other jsbin that reproduce the issue which help in further triaging it and also can you please confirm if this issue is specific to Ubuntu 18.04.

Thanks!
Making another jsbin isn't going to help. If that one doesn't show it in your environment, then your environment needs to change.
I don't have the facilities to try older versions of ubuntu since I have a real job that takes my time. I suggest you try upgrading your ubuntu to the new LTS and try it - I'm not sure why you're trying 14.04 since it's over 4 years old.
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 20

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: swarnasree.mukkala@chromium.org
Labels: TE-NeedsTriageFromMTV
As per comment#3 the issue seems to be related to Ubuntu 18.04, hence requesting someone MTV team to look into the issue and adding TE-NeedsTriageFromMTV label.

Thanks.!
Cc: l...@chromium.org
Thanks for letting us know!

Unable to reproduce on 73.0.3646.0 on gLinux and macOS. Guess it has something to do with Ubuntu 18.04's system fonts.
Screen Shot 2019-01-07 at 16.05.18.png
27.6 KB View Download
> Guess it has something to do with Ubuntu 18.04's system fonts.

Perhaps, but this doesn't happen with '71.0.3578.98 (Official Build) unknown (64-bit)' - see attached screenshot. It seems possible that it is an interaction between 73.0.3642.0 and 18.04...I just confirmed it still is a problem with that combination.
missing_underscore-jsbin-71.0.3578.98.png
29.4 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47b692a6943448ace76e2111a0c3a5d6c28af187

commit 47b692a6943448ace76e2111a0c3a5d6c28af187
Author: Erik Luo <luoe@chromium.org>
Date: Fri Jan 11 23:18:59 2019

DevTools: fix line-height for object properties sections

When zoomed in, object properties with underscores can be cutoff due
to overflow: hidden. This adjusts line-height to be more flexible.

Bug:  915708 
Change-Id: Ic8ef4aee2c97278b011db8a973274ce7d1e836b7
Reviewed-on: https://chromium-review.googlesource.com/c/1405981
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622206}
[modify] https://crrev.com/47b692a6943448ace76e2111a0c3a5d6c28af187/third_party/blink/renderer/devtools/front_end/object_ui/objectPropertiesSection.css

Owner: l...@chromium.org
Status: Fixed (was: Unconfirmed)
c#10: most likely, a change in CSS between 71 and 73 resulted in DevTools hiding overflow.

I checked the CL in c#11 with Linux w/ dejavu sans mono, Ubuntu Mono, and that it doesn't regress Mac/Win.  You can still run into hidden underscores if you modify your Chrome or OS settings to have an extremely large, custom font-size.
That's an interesting observation. The font is a lot smaller on 73.0.3642.0 than on 71.0.3578.98. I don't recall ever changing it (in either)...but you seem to suggest the opposite - ie I'm losing the underscore with smaller font, not with larger. Go figure.

Perhaps I can test by running chrome from command line without reading the settings? I can't find such a command, on first attempt of looking. Perhaps I need to create a new user.....OK, tried that and it is fine with both versions with a new user. Furthermore, if I 'zoom out' on the new version, I lose the underscores...'zoom in' again, and the come back. This seems to confirm it is related to font size, but nothing like 'extremely large, custom font-size'.

If I trying zooming out with my account, then I can get it to disappear with just one zoom out on 71.0.3578.98, and get them to appear again with just one zoom in on 73.0.3642.0.

Unfortunately, unlike with the browser itself, the dev tools don't seem to show if they are zoomed in or out at all, so I can't tell when they are at '100%'.

Anyway, it seems like this overflow thing is the key, and so hopefully you guys can now reproduce the problem.

Sign in to add a comment