This code is no longer really used, clean it up, and figure out a long term plan for the remaining users.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e905a2d80549580b60eee6689163002f92453868 commit e905a2d80549580b60eee6689163002f92453868 Author: David Roger <droger@chromium.org> Date: Mon Dec 17 15:27:32 2018 [signin] Delete OneClickSigninSyncStarter::start_mode_ This is dead code. BUG=915678 Change-Id: Ibda0e6271b09f7f534db7fc23f0f554c5a692a46 Reviewed-on: https://chromium-review.googlesource.com/c/1379961 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#617119} [modify] https://crrev.com/e905a2d80549580b60eee6689163002f92453868/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/e905a2d80549580b60eee6689163002f92453868/chrome/browser/ui/sync/one_click_signin_sync_starter.h [modify] https://crrev.com/e905a2d80549580b60eee6689163002f92453868/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc [modify] https://crrev.com/e905a2d80549580b60eee6689163002f92453868/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc [modify] https://crrev.com/e905a2d80549580b60eee6689163002f92453868/chrome/browser/ui/webui/signin/inline_login_handler_impl.h [modify] https://crrev.com/e905a2d80549580b60eee6689163002f92453868/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c50f4da01fae2c594f5058f7d40612e0af4bc0a2 commit c50f4da01fae2c594f5058f7d40612e0af4bc0a2 Author: David Roger <droger@chromium.org> Date: Tue Dec 18 09:05:49 2018 [signin] Delete OneClickSigninSyncObserver This is dead code. BUG=915678 Change-Id: I70d89763a805f44403255b9ba93f8db85ffdf118 Reviewed-on: https://chromium-review.googlesource.com/c/1379960 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#617423} [modify] https://crrev.com/c50f4da01fae2c594f5058f7d40612e0af4bc0a2/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/49afea193b9ed772788d9d2eb6872423de1cb8b3/chrome/browser/ui/sync/one_click_signin_sync_observer.cc [delete] https://crrev.com/49afea193b9ed772788d9d2eb6872423de1cb8b3/chrome/browser/ui/sync/one_click_signin_sync_observer.h [delete] https://crrev.com/49afea193b9ed772788d9d2eb6872423de1cb8b3/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc [modify] https://crrev.com/c50f4da01fae2c594f5058f7d40612e0af4bc0a2/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/c50f4da01fae2c594f5058f7d40612e0af4bc0a2/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/618d1c6934e8da4cc559b43b47a1312f8d5185aa commit 618d1c6934e8da4cc559b43b47a1312f8d5185aa Author: David Roger <droger@chromium.org> Date: Tue Jan 15 12:55:24 2019 [signin] Delete OneClickSigninSyncStarter::StartSyncMode This CL is a preparation for the complete removal of OneClickSigninSyncStarter. StartSyncMode was not really used (only 2 values out of the 4 were useful), and thus can be replaced easily by a boolean. TBR=braveyao, poromov, tommycli Bug: 915678 Change-Id: I89dc6d3aa0a65e6020fc34d1c5537af774d6647a Reviewed-on: https://chromium-review.googlesource.com/c/1406992 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#622832} [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/plugins/plugin_power_saver_browsertest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/sessions/session_restore_browsertest_chromeos.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/signin/chrome_signin_client.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/signin/chrome_signin_client_unittest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/signin/signin_util.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/ash/shelf_browsertest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/browser_window.h [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/sync/one_click_signin_sync_starter.h [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/uma_browsing_activity_observer.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/views/frame/system_menu_model_builder.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/views/sync/one_click_signin_dialog_view.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/views/sync/one_click_signin_dialog_view.h [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/views/sync/one_click_signin_dialog_view_unittest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/webui/components_ui.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/webui/signin/signin_error_ui.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc [modify] https://crrev.com/618d1c6934e8da4cc559b43b47a1312f8d5185aa/chrome/test/base/test_browser_window.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39e04f0ce0d8812a58afd112713f448cbe82e091 commit 39e04f0ce0d8812a58afd112713f448cbe82e091 Author: David Roger <droger@chromium.org> Date: Tue Jan 15 15:04:45 2019 [signin] Untrusted signin dialog is moved earlier in the signin flow This CL moves the untrusted signin dialog from the sync starter to the inline login handler. This will allow removing the sync starter code in a followup. Bug: 915678 Change-Id: Id7422813e72ca31c2ec6ddc2b42deef33e363d1c Reviewed-on: https://chromium-review.googlesource.com/c/1401065 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#622860} [modify] https://crrev.com/39e04f0ce0d8812a58afd112713f448cbe82e091/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/39e04f0ce0d8812a58afd112713f448cbe82e091/chrome/browser/ui/sync/one_click_signin_sync_starter.h [modify] https://crrev.com/39e04f0ce0d8812a58afd112713f448cbe82e091/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc [rename] https://crrev.com/39e04f0ce0d8812a58afd112713f448cbe82e091/chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc [modify] https://crrev.com/39e04f0ce0d8812a58afd112713f448cbe82e091/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc [modify] https://crrev.com/39e04f0ce0d8812a58afd112713f448cbe82e091/chrome/browser/ui/webui/signin/inline_login_handler_impl.h [modify] https://crrev.com/39e04f0ce0d8812a58afd112713f448cbe82e091/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5cb3963d0dc67f8daeb524a9ed4a6882476aaf1 commit f5cb3963d0dc67f8daeb524a9ed4a6882476aaf1 Author: David Roger <droger@chromium.org> Date: Wed Jan 16 15:01:31 2019 [signin] Remove SigninTracker usage from login_ui_test_utils SigninTracker is only used by deprecated signin flows and will be removed. Bug: 915678 Change-Id: I77b49971bfb1ac53873b3b091a6819ade7a19f26 Reviewed-on: https://chromium-review.googlesource.com/c/1414897 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#623235} [modify] https://crrev.com/f5cb3963d0dc67f8daeb524a9ed4a6882476aaf1/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c62f2264b7358f0c2c7c0a4a3f78554875619437 commit c62f2264b7358f0c2c7c0a4a3f78554875619437 Author: David Roger <droger@chromium.org> Date: Wed Jan 16 17:31:04 2019 [signin] Remove support for pre-Dice signin in login_ui_test_utils Bug: 915678 Change-Id: I3a2d39357f257fabe9c29c9a72284db854f7f860 Reviewed-on: https://chromium-review.googlesource.com/c/1411996 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#623275} [modify] https://crrev.com/c62f2264b7358f0c2c7c0a4a3f78554875619437/chrome/browser/BUILD.gn [modify] https://crrev.com/c62f2264b7358f0c2c7c0a4a3f78554875619437/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/848bbdf571a052bd0e5bd9987a7987343b3768fc commit 848bbdf571a052bd0e5bd9987a7987343b3768fc Author: David Roger <droger@chromium.org> Date: Wed Jan 16 19:35:32 2019 [signin] Cleanup embedded URL API in signin_promo This CL removes unused functions, moves the ChromeOS specific code under OS_CHROMEOS guards, and adds a "Embedded" prefix to the functions. TBR=ellyjones, tangltom Bug: 915678 Change-Id: Ica5e7ee5c40cb6fc40f3a9d09533357f21ae441a Reviewed-on: https://chromium-review.googlesource.com/c/1411593 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#623327} [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/profiles/host_zoom_map_browsertest.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/signin/signin_promo.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/signin/signin_promo.h [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/signin/signin_promo_unittest.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/browser_navigator.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/chrome_pages.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/startup/credential_provider_signin_dialog_win.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/user_manager.h [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/views/profiles/user_manager_view.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/profile_helper.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/signin/inline_login_handler.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/signin/signin_create_profile_handler.h [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc [modify] https://crrev.com/848bbdf571a052bd0e5bd9987a7987343b3768fc/chrome/browser/ui/webui/webui_webview_browsertest.cc
Comment 1 by droger@chromium.org
, Dec 17