New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 915676 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Ctrl+L doesn't always focus Omnibox (in context of dev tools)

Project Member Reported by deleplace@google.com, Dec 17

Issue description

Chrome Version       : 71.0.3578.98
OS Version:  Debian x86_64 GNU/Linux

What steps will reproduce the problem?
1. Hit Ctrl+T
2. Hit F12
3. Hit Ctrl+L
4. Type google.com
5. Hit <Enter>

What is the expected result?
After 3. the Omnibox has the focus.
After 5. the page loads and the network traffic is captured in the Dev Tools panel.

What happens instead of that?
3., 4., and 5. do nothing.
The page doesn't load, no network traffic is captured.


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36


When I open Dev Tools (F12) I'm most often interested in what's happening in the Network tab at first page load: HTTP requests, latencies, etc.
This information is not available if the page is already loaded or partially loaded. I acknowledge that the Dev Tools must be already open in order to gather and display the relevant data.

It is very important for me to be able to achieve this with the keyboard only, without touching the mouse. Unfortunately, the logical action sequence (F12, Ctrl+L) doesn't work for me.
 
Cc: kayce@chromium.org
Components: Platform>DevTools
Labels: OS-Chrome
Kayce, do you think you can help triage this issue?
The problem is the same if I decide to open the Dev Tools panel with F12, or Ctrl+Shift+J, or Ctrl+Shift+C.

When the Dev Tools is opened with the Console tab open, then the Ctrl+L action clears the console (but still doesn't focus the Omnibox).
A possible workaround is to use F6 instead of Ctrl+L.

However I've been using Chrome for many years without knowing about F6.
FWIW other working shortcuts in Windows are Alt-D (always) and Ctrl-E (intercepted in some devtools panels).

Bisected to 2e10f6482f3af7201b7be1cd8078efccd0eb8430
"Devtools UI: Show multiple shortcuts, show more shortcuts"
Landed in 47.0.2497.0 via r346247
Alt-D is magical and I had never heard of it. Thanks a ton!
Summary: Ctrl+L doesn't always focus Omnibox (in context of dev tools) (was: Ctrl+L doesn't always focus Omnibox)
Cc: santhoshkumar@chromium.org
Labels: -Pri-3 Triaged-ET Target-73 M-73 FoundIn-71 FoundIn-73 FoundIn-72 Need-Triage-M71 Pri-2
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on reported chrome version # 71.0.3578.98 also on latest chrome # 73.0.3645.0 using Ubuntu 17.10 and Windows 10.  
Same behavior is seen on M60(60.0.3072.0) hence considering it as non-regression and marking it as Untriaged.
Note: Not observed in mac os 10.14.0

Thanks! 
Hi - 

I think the implementation is currently working as intended; Ctrl+L is listed as "clear console" on:
https://developers.google.com/web/tools/chrome-devtools/shortcuts

Leaving this open in case the implementation is as intended but the shortcut would be reassigned by the team.

On Mac, there's no competition for Command-L as noted.

Owner: l...@chromium.org
Status: Assigned (was: Untriaged)
From the DevTools side, this shortcut is intended, and changing it would likely cause developer pain.  However, we can focus the Omnibox whenever the Console is not showing (e.g. another panel is open, or Console is minimized in drawer).  I'll take a look at making the shortcut context aware.
Thanks Erik!
F6 or Alt-D are awesome, for those who already know them.
Making Ctrl+D context-aware in DevTools, when console is not in use, would double-plus-awesome :)
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a858d1d9aa7a2043f87f538d6d61aa174c3fbe01

commit a858d1d9aa7a2043f87f538d6d61aa174c3fbe01
Author: Erik Luo <luoe@chromium.org>
Date: Fri Jan 11 23:22:39 2019

DevTools: context-aware console.clear, element.hide shortcuts

Before, pressing 'H' or 'Ctrl+L' on ANY panel would perform the
action (hide selected element, clear console). This CL makes both
shortcuts execute only when the respective panel/view is showing.

This allows 'Ctrl+L' to focus Omnibox when Console is not visible.

Bug:  915676 
Change-Id: Ie5ef04786fcd240a393524f429cb45a3951cd5d0
Reviewed-on: https://chromium-review.googlesource.com/c/1405701
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622211}
[modify] https://crrev.com/a858d1d9aa7a2043f87f538d6d61aa174c3fbe01/third_party/blink/renderer/devtools/front_end/console/ConsolePanel.js
[modify] https://crrev.com/a858d1d9aa7a2043f87f538d6d61aa174c3fbe01/third_party/blink/renderer/devtools/front_end/console/module.json
[modify] https://crrev.com/a858d1d9aa7a2043f87f538d6d61aa174c3fbe01/third_party/blink/renderer/devtools/front_end/elements/ElementsPanel.js

Status: Fixed (was: Assigned)

Sign in to add a comment