New issue
Advanced search Search tips

Issue 915669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 914784



Sign in to add a comment

Missing white-space reattaching child of <content>

Project Member Reported by futhark@chromium.org, Dec 17

Issue description

We incorrectly use a new WhitespaceAttacher for <content> elements during RebuildLayoutTree. We should instead handle it like display:contents.

 
content2.html
274 bytes View Download
Blocking: 914784
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/157d9c65bb9a5b9c5fb0fb37543830679e1846d4

commit 157d9c65bb9a5b9c5fb0fb37543830679e1846d4
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Dec 17 19:50:19 2018

Do not use a local WhitespaceAttacher for <content>.

<content> elements are not in the flat tree and should be treated like
display:contents in order to attach whitespace LayoutText objects
correctly.

This bug caused regressions for the unification of ComputedStyle
storage.

Bug:  915669 , 914784
Change-Id: I8afce3bd7fd67244a8784e17acbefc6dd068a8e3
Reviewed-on: https://chromium-review.googlesource.com/c/1379767
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617193}
[modify] https://crrev.com/157d9c65bb9a5b9c5fb0fb37543830679e1846d4/third_party/blink/renderer/core/dom/element.cc
[add] https://crrev.com/157d9c65bb9a5b9c5fb0fb37543830679e1846d4/third_party/blink/web_tests/fast/dom/shadow/content-whitespace-attach-expected.html
[add] https://crrev.com/157d9c65bb9a5b9c5fb0fb37543830679e1846d4/third_party/blink/web_tests/fast/dom/shadow/content-whitespace-attach-expected.txt
[add] https://crrev.com/157d9c65bb9a5b9c5fb0fb37543830679e1846d4/third_party/blink/web_tests/fast/dom/shadow/content-whitespace-attach.html

Status: Fixed (was: Started)

Sign in to add a comment