New issue
Advanced search Search tips

Issue 915658 link

Starred by 1 user
Status: Fixed
Owner:
noel@chromium.org
Closed: Dec 18
Cc:
kylixrd@chromium.org
pkasting@chromium.org
songsuk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Mixed Content Dialog i18 message $1 placeholder should be wrapped in a <ph> element

Project Member Reported by noel@chromium.org, Dec 17 
https://chromium-review.googlesource.com/c/chromium/src/+/612496 added an i18n message

./chrome/app/generated_resources.grd
  string IDS_LIST_BULLET
    "•  $1"

Placeholder elements like $1 $2, should be wrapped in <ph> elements according to the docs [1] [2]

[1] https://sites.google.com/a/chromium.org/dev/developers/design-documents/ui-localization#TOC-How-to-add-a-string
[2] https://sites.google.com/a/chromium.org/dev/developers/tools-we-use-in-chromium/grit/grit-users-guide#Adding_Resources

along with and <ex> element giving an example.

   <ph name="DIALOG_TITLE">$1<ex>Title</ex></ph>

When this is not done, applications can fail to work when reading the i18n translated strings, sadly.

Can we please fix?

Comment 1 by noel@chromium.org, Dec 17

Labels: bad-i18n-placeholders

Comment 2 by noel@chromium.org, Dec 18 

https://bugs.chromium.org/p/chromium/issues/detail?id=908888#c6 found an example of this $1 causing a translation error.

./chrome/app/resources/generated_resources_bn.xtb
<translation id="7837307963048806839">• $১</translation>

Since the $1 in the <message> is not in a <ph>, translators are allowed to translate it, and they do it seems.

Comment 3 by noel@chromium.org, Dec 18

Cc: kylixrd@chromium.org
Owner: noel@chromium.org
Since the $1 appears to be some kind of item text, we'll lemme fix it ...

Comment 4 by noel@chromium.org, Dec 18

Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/142e59f1d2a598b8eed359087a5d1795c395c94c

commit 142e59f1d2a598b8eed359087a5d1795c395c94c
Author: Noel Gordon <noel@chromium.org>
Date: Tue Dec 18 04:10:04 2018

Fix Mixed Content Dialog i18n message placeholder

The placeholder $1 in the IDS_LIST_BULLET <message> content should be
wrapped in a <ph> placeholder element per the Chrome i18n docs:

https://sites.google.com/a/chromium.org/dev/developers/design-documents/ui-localization#TOC-How-to-add-a-string
https://sites.google.com/a/chromium.org/dev/developers/tools-we-use-in-chromium/grit/grit-users-guide#Adding_Resources

Bug:  915658 
Change-Id: I3596801c09a7fad0826012953c7ba87f8a3fbada
Reviewed-on: https://chromium-review.googlesource.com/c/1381357
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617374}
[modify] https://crrev.com/142e59f1d2a598b8eed359087a5d1795c395c94c/chrome/app/generated_resources.grd

Comment 6 by noel@chromium.org, Dec 18

Status: Fixed (was: Started)
►

Sign in to add a comment