Fix MobileMenu metrics |
||||||
Issue descriptionThe metrics for ReadLater and Request Desktop Site aren't logged for the share menu. Also, a metrics for logging when the user cancels the menu should be added.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50a84a885d0a54cfb1b72884ea9a1bfc5ec7ad81 commit 50a84a885d0a54cfb1b72884ea9a1bfc5ec7ad81 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Dec 19 08:45:23 2018 [iOS] Fix ShareMenu metrics This CL fixes the reporting the metrics of the share menu. Previously GOOGLE_UNKNOWN was taking precedence over the ReadLater and RequestDesktopMobile. It also adds a metrics when the user is cancelling the share menu. Bug: 915654 Change-Id: Ief8580866f16ce3ce68c3f197bf1a013ff0bd282 Reviewed-on: https://chromium-review.googlesource.com/c/1379895 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#617770} [modify] https://crrev.com/50a84a885d0a54cfb1b72884ea9a1bfc5ec7ad81/ios/chrome/browser/ui/activity_services/activity_service_controller.mm [modify] https://crrev.com/50a84a885d0a54cfb1b72884ea9a1bfc5ec7ad81/ios/chrome/browser/ui/activity_services/activity_type_util.mm [modify] https://crrev.com/50a84a885d0a54cfb1b72884ea9a1bfc5ec7ad81/tools/metrics/actions/actions.xml
,
Dec 19
Asking for merge request. This is only fixing the way metrics are collected so it is low risk. It is also hard to test on canary as there is no user visible changes.
,
Dec 19
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 4
Approved. Please merge asap.
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e595abb3b366e5df1d5b4b8ed2f4c384a66abff commit 8e595abb3b366e5df1d5b4b8ed2f4c384a66abff Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Jan 07 10:35:25 2019 [iOS] Fix ShareMenu metrics This CL fixes the reporting the metrics of the share menu. Previously GOOGLE_UNKNOWN was taking precedence over the ReadLater and RequestDesktopMobile. It also adds a metrics when the user is cancelling the share menu. Bug: 915654 Change-Id: Ief8580866f16ce3ce68c3f197bf1a013ff0bd282 Reviewed-on: https://chromium-review.googlesource.com/c/1379895 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617770}(cherry picked from commit 50a84a885d0a54cfb1b72884ea9a1bfc5ec7ad81) Reviewed-on: https://chromium-review.googlesource.com/c/1397630 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#582} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/8e595abb3b366e5df1d5b4b8ed2f4c384a66abff/ios/chrome/browser/ui/activity_services/activity_service_controller.mm [modify] https://crrev.com/8e595abb3b366e5df1d5b4b8ed2f4c384a66abff/ios/chrome/browser/ui/activity_services/activity_type_util.mm [modify] https://crrev.com/8e595abb3b366e5df1d5b4b8ed2f4c384a66abff/tools/metrics/actions/actions.xml
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e595abb3b366e5df1d5b4b8ed2f4c384a66abff Commit: 8e595abb3b366e5df1d5b4b8ed2f4c384a66abff Author: gambard@chromium.org Commiter: gambard@chromium.org Date: 2019-01-07 10:35:25 +0000 UTC [iOS] Fix ShareMenu metrics This CL fixes the reporting the metrics of the share menu. Previously GOOGLE_UNKNOWN was taking precedence over the ReadLater and RequestDesktopMobile. It also adds a metrics when the user is cancelling the share menu. Bug: 915654 Change-Id: Ief8580866f16ce3ce68c3f197bf1a013ff0bd282 Reviewed-on: https://chromium-review.googlesource.com/c/1379895 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617770}(cherry picked from commit 50a84a885d0a54cfb1b72884ea9a1bfc5ec7ad81) Reviewed-on: https://chromium-review.googlesource.com/c/1397630 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#582} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pkl@chromium.org
, Dec 17