User Remove Warning i18 message $1 placeholder should be wrapped in a <ph> element |
||||
Issue descriptionhttps://codereview.chromium.org/2265133003 added an i18n message ./chrome/app/profiles_strings.grdp string IDS_LOGIN_POD_NON_OWNER_USER_REMOVE_WARNING All files and local data associated with this user will be permanently deleted once this user is removed. $1 can still sign in later. Placeholder elements like $1 $2, should be wrapped in <ph> elements according to the docs [1] [2] [1] https://sites.google.com/a/chromium.org/dev/developers/design-documents/ui-localization#TOC-How-to-add-a-string [2] https://sites.google.com/a/chromium.org/dev/developers/tools-we-use-in-chromium/grit/grit-users-guide#Adding_Resources along with and <ex> element giving an example. <ph name="USER_EMAIL">$1<ex>foo@example.com</ex></ph> When this is not done, applications can fail to work when reading the i18n translated strings, sadly. Can we please fix?
,
Dec 18
Adding browser/profiles peeps.
,
Dec 19
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd318c1409dffc3444696d103bb17053d632da3c commit fd318c1409dffc3444696d103bb17053d632da3c Author: Noel Gordon <noel@chromium.org> Date: Wed Dec 19 06:15:06 2018 Fix i18n User Remove Warning message $1 placeholder Placeholders should be wrapped in a <ph> element per the the chromium i18n docs [1][2]. The $1 here is a user e-mail: <ph> wrap it, and add an <ex> e-mail example. [1] https://sites.google.com/a/chromium.org/dev/developers/design-documents/ui-localization#TOC-How-to-add-a-string [2] https://sites.google.com/a/chromium.org/dev/developers/tools-we-use-in-chromium/grit/grit-users-guide#Adding_Resources Tbr: msarda@ Bug: 915652 Change-Id: I2a0e35dacd5667c6f37dbd3aa2a31883c43356a1 Reviewed-on: https://chromium-review.googlesource.com/c/1382716 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#617740} [modify] https://crrev.com/fd318c1409dffc3444696d103bb17053d632da3c/chrome/app/profiles_strings.grdp
,
Dec 19
|
||||
►
Sign in to add a comment |
||||
Comment 1 by noel@chromium.org
, Dec 17