Remove Warning Sync i18n message $2 placeholders should be wrapped in a <ph> element |
||||
Issue descriptionhttps://codereview.chromium.org/2960613002 added two i18n message strings 1) ./chrome/app/chromium_strings.grd string IDS_LOGIN_POD_USER_REMOVE_WARNING_SYNC This person's browsing data will be deleted from this device. To recover the data, sign in to Chromium as $2. 2) ./chrome/app/google_chrome_strings.grd string IDS_LOGIN_POD_USER_REMOVE_WARNING_SYNC This person's browsing data will be deleted from this device. To recover the data, sign in to Chrome as $2. Placeholder elements like $1 $2, should be wrapped in <ph> elements according to the docs [1] [2] [1] https://sites.google.com/a/chromium.org/dev/developers/design-documents/ui-localization#TOC-How-to-add-a-string [2] https://sites.google.com/a/chromium.org/dev/developers/tools-we-use-in-chromium/grit/grit-users-guide#Adding_Resources along with and <ex> element giving an example. <ph name="USER_EMAIL">$2<ex>foo@example.com</ex></ph> When this is not done, applications can fail to work when reading the i18n translated strings, sadly. There are 2 error cases, can we please fix?
,
Dec 17
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5d05a9dbb44dc619c615c6b436b53bac3e3f043 commit d5d05a9dbb44dc619c615c6b436b53bac3e3f043 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Dec 17 15:31:12 2018 Fix missing <ph> element for string placeholder All placeholders should be wrapped in a <ph> and have an example. Bug: 915645 Change-Id: I2c09fc262d0695e8b846f1af3b9ca169e56c1f08 Reviewed-on: https://chromium-review.googlesource.com/c/1379956 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#617121} [modify] https://crrev.com/d5d05a9dbb44dc619c615c6b436b53bac3e3f043/chrome/app/chromium_strings.grd [modify] https://crrev.com/d5d05a9dbb44dc619c615c6b436b53bac3e3f043/chrome/app/google_chrome_strings.grd
,
Dec 17
,
Dec 18
Thank you for landing a fix so quickly Christian.
,
Dec 19
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dullweber@google.com
, Dec 17