New issue
Advanced search Search tips

Issue 915630 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
sadrul@chromium.org
yhanada@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Task



Sign in to add a comment

Add unit tests for RWHVA::SetEditableSelectionRange and RWHVA::ExtendSelectionAndDelete.

Project Member Reported by yhanada@chromium.org, Dec 17 
These two methods depend on FrameInputHandler(h, so it's difficult to write unit tests for them in render_widget_host_view_aura_unittest.cc.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2bcc4086a602714ae69fcbdc883e409c7c7839

commit df2bcc4086a602714ae69fcbdc883e409c7c7839
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Mon Dec 17 11:36:40 2018

Implement RWHVA::SetEditableSelectionRange.

The operation is already implemented by FrameInputHandler, so the added
implementation just calls it.

Bug:  908800 , 915630
Change-Id: I19fdb51ac02e67fc94306448a8d3901ff8cbb56a
Reviewed-on: https://chromium-review.googlesource.com/c/1352076
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617086}
[modify] https://crrev.com/df2bcc4086a602714ae69fcbdc883e409c7c7839/content/browser/renderer_host/render_widget_host_view_aura.cc
►

Sign in to add a comment