New issue
Advanced search Search tips

Issue 915615 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 841121



Sign in to add a comment

servod: generate servo lockfile in hdctools

Project Member Reported by coconutruben@chromium.org, Dec 17

Issue description

In crrev.com/c/ servod starts using a lockfile to ensure that multiple servo instances cannot be initialized at the same time. This is to ensure that at least as far as servo devices on the system are concerned, the snapshot at the beginning of the servod initialization is semi-accurate by the time hwinit() and serving the instance on localhost rolls around.

Right now in the WIP (and maybe in the check-in version as well when it comes to that) the lockfile is generated lazily by the first servod instance that needs it.

It might be more robust to generate the lockfile when building hdctools.

From glancing over it, it seems to me that inside src_build the python's build script has access to the packages, and could leave some breadcrumbs around to indicate where the lockfile should be installed.

Questions to vapier@:
- In general, how do I shuttle information found/generate in src_build to be used in src_install? files, environment variables?
- If I'm trying to generate an empty lockfile can I just echo "" into that lockfile, or should I have an empty lockfile ready to go inside files/ of the ebuild?
- Usually, where do these type of files get placed? /var/? /etc/?
 
sorry, the first line should say: crrev.com/c/1348514
ebuilds may not create files under paths like /var or /run or /tmp, so there would never be a way for it to precreate paths in ebuilds

for lock files, /run/lock/ is the correct place

Sign in to add a comment