New issue
Advanced search Search tips

Issue 915609 link

Starred by 5 users
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jan 3
Cc:
pbos@chromium.org
nyerramilli@chromium.org
kylixrd@chromium.org
rbasuvula@chromium.org
taku...@chromium.org
amyroberts@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Recording favicon in Tab Strip is seen black in colour.

Project Member Reported by shru...@virtusa.com, Dec 17 
Chrome version: 73.0.3643.0 (Official Build)    Revision310dbdcb8884c1a70ee5cc78c7527778870ea067-refs/branch-heads/3643@{#1}(64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.6,10.13.1,10.14.2)

Test URL:https://chrome.google.com/webstore/detail/screencastify-screen-vide/mmeijimgabbpbgpdklnllpncmdofkcpn?hl=en-GB

What steps will reproduce the problem?
1. Launch chrome and Navigate to above URL.
2. Add extension and Login with valid credentials for recording activities.
3. Click on extension icon for recording ,select browser for recording.
4. Observe Recording favicon in Tab Strip .

Actual Result   :Recording favicon in Tab Strip is seen black in colour.
Expected Result :Recording favicon in Tab Strip should be seen blue in colour.

This is a regression issue broken in M-72 and will below is the bisect info:
Good Build : 72.0.3606.0
Bad Build  : 72.0.3607.0


CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/1ec65ecb8bdf7984d02663faed8e17c953ca2521..7762ab842197ba5815e974f3b125b43eed1c02b6	

Suspect:https://chromium.googlesource.com/chromium/src/+/7762ab842197ba5815e974f3b125b43eed1c02b6

@Allen Bauer  :Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.	

Note :Pardon me if it is intended as in dark theme Recording favicon is not seen.

Kindly refer the attached screencast .
https://drive.google.com/open?id=1kXe4tu6wdbNN9taXqL5ivhK23zCpDbbp

Thank you..!
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e51839d8198a7f40ccf0a25cfa48900c4204f6ec

commit e51839d8198a7f40ccf0a25cfa48900c4204f6ec
Author: Allen Bauer <kylixrd@chromium.org>
Date: Thu Jan 03 15:37:37 2019

Use the same color for the capturing icon for touch and non-touch.

Bug:  915609 
Change-Id: Iabc4219958f5d0411e8911b9a2f4e9de1573b68d
Reviewed-on: https://chromium-review.googlesource.com/c/1393262
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619642}
[modify] https://crrev.com/e51839d8198a7f40ccf0a25cfa48900c4204f6ec/chrome/browser/ui/views/tabs/tab.cc

Comment 2 by kylixrd@chromium.org, Jan 3

Status: Fixed (was: Assigned)

Comment 3 by shru...@virtusa.com, Jan 7

Labels: TE-Verified-M73 TE-Verified-73.0.3664.0
Update:
Retested above issue on  OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.6,10.13.1,10.14.2)using latest Canary #73.0.3664.0 issue is fixed.
Now,Recording favicon in Tab Strip is seen blue in colour.

Kindly review the attached screen-cast from drive link.
https://drive.google.com/open?id=13nBApdWc234xN7xaVLynHJflb1fe9YTL

Thank you!

Comment 4 by kylixrd@chromium.org, Jan 8

Cc: kylixrd@chromium.org amyroberts@chromium.org taku...@chromium.org pbos@chromium.org
 Issue 905473  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1d72d368873aebd39537d5725de69f94d290843

commit d1d72d368873aebd39537d5725de69f94d290843
Author: Allen Bauer <kylixrd@chromium.org>
Date: Wed Jan 09 22:18:21 2019

Use the same colors for non-touch & touch for audio tab alert icons.

Bug:  915609 
Change-Id: Ie9a48b3bb401d060ee977a816b54fa3772d3a0d9
Reviewed-on: https://chromium-review.googlesource.com/c/1398286
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621330}
[modify] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/chrome/browser/ui/views/tabs/tab.cc

Comment 6 by shru...@virtusa.com, Jan 10

Labels: TE-Verified-73.0.3667.0
Update:
Retested above issue on  OS : Mac(10.13.6, 10.13.1, 10.14.3), Windows(7,8,10) and Linux(14.04 LTS)using latest Canary #73.0.3667.0 issue is fixed.
Now, Recording favicon in Tab Strip is seen blue in colour.

Kindly review the attached screen-cast.
https://drive.google.com/open?id=1_A58czLJCu4vhWjV1YBO-toRjDwA5fR_
Thank you!
►

Sign in to add a comment