New issue
Advanced search Search tips

Issue 915591 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
tommycli@chromium.org
jdonnelly@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Flaky interactive_ui_tests failing on chromium.mac/Mac10.11 Tests (OmniboxViewViewsTest.SelectAllOnClick)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 17 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of shimazu@chromium.org

interactive_ui_tests failing on chromium.mac/Mac10.11 Tests

Builders failed on: 
- Mac10.11 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests

OmniboxViewViewsTest.SelectAllOnClick is flaky on Mac and TSan.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=OmniboxViewViewsTest

Comment 1 by shimazu@chromium.org, Dec 17

Cc: -shimazu@chromium.org jdonnelly@chromium.org
Components: UI>Browser>Omnibox
Labels: Test-Flaky OS-Mac
Added an owner of the test.

Comment 2 by droger@chromium.org, Dec 17

Owner: sky@chromium.org
Status: Assigned (was: Available)
Assigning to sky, as per comment in the code:
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc?rcl=bd70ec8c7cf5884fbf517d6b3122b6c29a3a2b9b&l=174

Comment 3 by droger@chromium.org, Dec 17 

[ RUN      ] OmniboxViewViewsTest.SelectAllOnClick
[24292:3843:1216/213928.003298:WARNING:notification_platform_bridge_mac.mm(521)] AlertNotificationService: XPC connection invalidated.
../../chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:191: Failure
Value of: ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX)
  Actual: false
Expected: true
Stack trace:
0   interactive_ui_tests                0x000000010b5abe6b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   interactive_ui_tests                0x000000010b5ab829 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   interactive_ui_tests                0x000000010b51774d OmniboxViewViewsTest_SelectAllOnClick_Test::RunTestOnMainThread() + 1101
3   interactive_ui_tests                0x000000010ea7672b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   interactive_ui_tests                0x000000010e475a2f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4319
5   interactive_ui_tests                0x000000010e47488d ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
6   interactive_ui_tests                0x000000010c69e462 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
7   interactive_ui_tests                0x000000010cb067c7 content::StartupTaskRunner::RunAllTasksNow() + 39
8   interactive_ui_tests                0x000000010c69d00b content::BrowserMainLoop::CreateStartupTasks() + 683
9   interactive_ui_tests                0x000000010c6a0665 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
10  interactive_ui_tests                0x000000010c69b472 content::BrowserMain(content::MainFunctionParams const&) + 178
11  interactive_ui_tests                0x000000010e018250 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 848
12  interactive_ui_tests                0x000000010e017ed4 content::ContentMainRunnerImpl::Run(bool) + 292
13  interactive_ui_tests                0x00000001113b08d0 service_manager::Main(service_manager::MainParams const&) + 2352
14  interactive_ui_tests                0x000000010e017084 content::ContentMain(content::ContentMainParams const&) + 68
15  interactive_ui_tests                0x000000010ea7637d content::BrowserTestBase::SetUp() + 2829
16  interactive_ui_tests                0x000000010e41a2a1 InProcessBrowserTest::SetUp() + 529

../../chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:192: Failure
Value of: omnibox_view->IsSelectAll()
  Actual: false
Expected: true
Stack trace:
0   interactive_ui_tests                0x000000010b5abe6b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   interactive_ui_tests                0x000000010b5ab829 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   interactive_ui_tests                0x000000010b51782e OmniboxViewViewsTest_SelectAllOnClick_Test::RunTestOnMainThread() + 1326
3   interactive_ui_tests                0x000000010ea7672b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   interactive_ui_tests                0x000000010e475a2f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4319
5   interactive_ui_tests                0x000000010e47488d ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
6   interactive_ui_tests                0x000000010c69e462 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
7   interactive_ui_tests                0x000000010cb067c7 content::StartupTaskRunner::RunAllTasksNow() + 39
8   interactive_ui_tests                0x000000010c69d00b content::BrowserMainLoop::CreateStartupTasks() + 683
9   interactive_ui_tests                0x000000010c6a0665 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
10  interactive_ui_tests                0x000000010c69b472 content::BrowserMain(content::MainFunctionParams const&) + 178
11  interactive_ui_tests                0x000000010e018250 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 848
12  interactive_ui_tests                0x000000010e017ed4 content::ContentMainRunnerImpl::Run(bool) + 292
13  interactive_ui_tests                0x00000001113b08d0 service_manager::Main(service_manager::MainParams const&) + 2352
14  interactive_ui_tests                0x000000010e017084 content::ContentMain(content::ContentMainParams const&) + 68
15  interactive_ui_tests                0x000000010ea7637d content::BrowserTestBase::SetUp() + 2829
16  interactive_ui_tests                0x000000010e41a2a1 InProcessBrowserTest::SetUp() + 529

../../chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:202: Failure
Value of: ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX)
  Actual: false
Expected: true
Stack trace:
0   interactive_ui_tests                0x000000010b5abe6b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   interactive_ui_tests                0x000000010b5ab829 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   interactive_ui_tests                0x000000010b517bac OmniboxViewViewsTest_SelectAllOnClick_Test::RunTestOnMainThread() + 2220
3   interactive_ui_tests                0x000000010ea7672b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   interactive_ui_tests                0x000000010e475a2f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4319
5   interactive_ui_tests                0x000000010e47488d ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
6   interactive_ui_tests                0x000000010c69e462 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
7   interactive_ui_tests                0x000000010cb067c7 content::StartupTaskRunner::RunAllTasksNow() + 39
8   interactive_ui_tests                0x000000010c69d00b content::BrowserMainLoop::CreateStartupTasks() + 683
9   interactive_ui_tests                0x000000010c6a0665 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
10  interactive_ui_tests                0x000000010c69b472 content::BrowserMain(content::MainFunctionParams const&) + 178
11  interactive_ui_tests                0x000000010e018250 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 848
12  interactive_ui_tests                0x000000010e017ed4 content::ContentMainRunnerImpl::Run(bool) + 292
13  interactive_ui_tests                0x00000001113b08d0 service_manager::Main(service_manager::MainParams const&) + 2352
14  interactive_ui_tests                0x000000010e017084 content::ContentMain(content::ContentMainParams const&) + 68
15  interactive_ui_tests                0x000000010ea7637d content::BrowserTestBase::SetUp() + 2829
16  interactive_ui_tests                0x000000010e41a2a1 InProcessBrowserTest::SetUp() + 529

../../chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:203: Failure
Value of: omnibox_view->IsSelectAll()
  Actual: false
Expected: true
Stack trace:
0   interactive_ui_tests                0x000000010b5abe6b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   interactive_ui_tests                0x000000010b5ab829 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   interactive_ui_tests                0x000000010b517c8d OmniboxViewViewsTest_SelectAllOnClick_Test::RunTestOnMainThread() + 2445
3   interactive_ui_tests                0x000000010ea7672b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   interactive_ui_tests                0x000000010e475a2f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4319
5   interactive_ui_tests                0x000000010e47488d ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
6   interactive_ui_tests                0x000000010c69e462 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
7   interactive_ui_tests                0x000000010cb067c7 content::StartupTaskRunner::RunAllTasksNow() + 39
8   interactive_ui_tests                0x000000010c69d00b content::BrowserMainLoop::CreateStartupTasks() + 683
9   interactive_ui_tests                0x000000010c6a0665 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
10  interactive_ui_tests                0x000000010c69b472 content::BrowserMain(content::MainFunctionParams const&) + 178
11  interactive_ui_tests                0x000000010e018250 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 848
12  interactive_ui_tests                0x000000010e017ed4 content::ContentMainRunnerImpl::Run(bool) + 292
13  interactive_ui_tests                0x00000001113b08d0 service_manager::Main(service_manager::MainParams const&) + 2352
14  interactive_ui_tests                0x000000010e017084 content::ContentMain(content::ContentMainParams const&) + 68
15  interactive_ui_tests                0x000000010ea7637d content::BrowserTestBase::SetUp() + 2829
16  interactive_ui_tests                0x000000010e41a2a1 InProcessBrowserTest::SetUp() + 529

../../chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:212: Failure
Value of: omnibox_view->IsSelectAll()
  Actual: true
Expected: false
Stack trace:
0   interactive_ui_tests                0x000000010b5abe6b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   interactive_ui_tests                0x000000010b5ab829 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   interactive_ui_tests                0x000000010b517f26 OmniboxViewViewsTest_SelectAllOnClick_Test::RunTestOnMainThread() + 3110
3   interactive_ui_tests                0x000000010ea7672b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   interactive_ui_tests                0x000000010e475a2f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4319
5   interactive_ui_tests                0x000000010e47488d ChromeBrowserMainParts::PreMainMessageLoopRun() + 45
6   interactive_ui_tests                0x000000010c69e462 content::BrowserMainLoop::PreMainMessageLoopRun() + 50
7   interactive_ui_tests                0x000000010cb067c7 content::StartupTaskRunner::RunAllTasksNow() + 39
8   interactive_ui_tests                0x000000010c69d00b content::BrowserMainLoop::CreateStartupTasks() + 683
9   interactive_ui_tests                0x000000010c6a0665 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 85
10  interactive_ui_tests                0x000000010c69b472 content::BrowserMain(content::MainFunctionParams const&) + 178
11  interactive_ui_tests                0x000000010e018250 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 848
12  interactive_ui_tests                0x000000010e017ed4 content::ContentMainRunnerImpl::Run(bool) + 292
13  interactive_ui_tests                0x00000001113b08d0 service_manager::Main(service_manager::MainParams const&) + 2352
14  interactive_ui_tests                0x000000010e017084 content::ContentMain(content::ContentMainParams const&) + 68
15  interactive_ui_tests                0x000000010ea7637d content::BrowserTestBase::SetUp() + 2829
16  interactive_ui_tests                0x000000010e41a2a1 InProcessBrowserTest::SetUp() + 529

[24292:775:1216/213929.053516:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[24292:775:1216/213929.053547:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.

Comment 4 by droger@chromium.org, Dec 17

Labels: -Sheriff-Chromium

Comment 5 by sky@chromium.org, Dec 17

Cc: ellyjo...@chromium.org
Owner: ----
Status: Available (was: Assigned)
523255 was specific to Windows. This looks specific to Mac. I'm removing myself as owner and will update the comment in the thest.

Comment 6 by mpear...@chromium.org, Dec 17 

CC tommycli@, are you planning as part of bug 751031 to convert flaky OmniboxViewViewsTest tests to unit tests as well?

Comment 7 by mpear...@chromium.org, Dec 17

Cc: tommycli@chromium.org
Oops, actually CCing tommycli@ per comment 6.

Comment 8 by thestig@chromium.org, Dec 18

Labels: Type-Bug
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6a855e015806cc9dccfd587c949cc410bcd965c

commit d6a855e015806cc9dccfd587c949cc410bcd965c
Author: Max Morin <maxmorin@chromium.org>
Date: Mon Jan 07 10:20:32 2019

Disable OmniboxViewViewsTest.SelectAllOnClick

Tbr: tommycli
Bug: 915591
Change-Id: I96a9710ca4b9bdb79a68db4effa39ab590c3f8fa
Reviewed-on: https://chromium-review.googlesource.com/c/1397626
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620282}
[modify] https://crrev.com/d6a855e015806cc9dccfd587c949cc410bcd965c/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
►

Sign in to add a comment