Issue 915584 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	joelhockey@chromium.org
Closed:	Dec 19
Components:	Platform>Apps>FileManager
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug-Regression
M-72 CrOSFilesCategory-UI CrOSFilesFeature-FileIntents

File tasks are not visible in context menu after opening selection menu

Project Member Reported by sa...@chromium.org, Dec 17

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/1347957 changed selection menus to leave 'toolbar-menu' on the menu element when hiding, relying on the activated menu item to clean up. However, the menu can be closed without activating an item; in this case, 'toolbar-menu' remains on the menu and the tasks are no longer displayed until a menu item is activated.

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6427f9424f8f2f0a6849ef2c01e10e35365b04e

commit e6427f9424f8f2f0a6849ef2c01e10e35365b04e
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Dec 19 02:06:04 2018

Fix FilesApp menu toolbar-menu toggling

Bug:  915584 
Change-Id: I653c65fbae2998f88f8bbf5418cc48b7ce01c62e
Reviewed-on: https://chromium-review.googlesource.com/c/1382659
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617711}
[modify] https://crrev.com/e6427f9424f8f2f0a6849ef2c01e10e35365b04e/chrome/browser/chromeos/file_manager/file_manager_uitest.cc
[modify] https://crrev.com/e6427f9424f8f2f0a6849ef2c01e10e35365b04e/ui/file_manager/file_manager/foreground/js/selection_menu_controller.js
[modify] https://crrev.com/e6427f9424f8f2f0a6849ef2c01e10e35365b04e/ui/file_manager/file_manager/test/BUILD.gn
[add] https://crrev.com/e6427f9424f8f2f0a6849ef2c01e10e35365b04e/ui/file_manager/file_manager/test/menu.js

Comment 2 by joelhockey@chromium.org, Dec 19

Status: Fixed (was: Assigned)

►

Issue 915584 link

Issue metadata

File tasks are not visible in context menu after opening selection menu

Issue description

Comment 1 by bugdroid1@chromium.org, Dec 19

Comment 1 Deleted

Comment 2 by joelhockey@chromium.org, Dec 19

Comment 2 Deleted

Sign in to add a comment