New issue
Advanced search Search tips

Issue 915581 link

Starred by 1 user
Status: Verified
Owner:
johntlee@chromium.org
Closed: Dec 18
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Separator line is not seen above 'Manage search engines' option in chrome://settings page.

Reported by rp...@virtusa.com, Dec 17 
Chrome Version: 73.0.3642.0 (Official Build) Revision	e581247c6782059ec062f68e412a3628ccdf8821-refs/branch-heads/3642@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.14.2,10.13.1,10.13.6)and Linux(14.04 LTs).
             
Steps to reproduce:
1. Launch chrome, navigate to chrome://settings page
2. Now scroll down the page and observe 'Manage search engines'

Actual Result: Separator line is not seen above 'Manage search engines' option 
Expected Result: Separator line should be seen above 'Manage search engines' option 

This is a regression issue, broken in 'M-73', and will soon update other info :
Good Build:73.0.3641.0 (Revision:616889)
Bad Build: 73.0.3642.0 (Revision:616996)
Actual_screenshot.png
235 KB View Download
Expected_screenshot.png
248 KB View Download

Comment 1 by rp...@virtusa.com, Dec 17

Labels: hasbisect-per-revision
Owner: johntlee@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 616928 (known good), but no later than 616929 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/d1c3e84f4abf4be12a67d886f5d7ef2b5b522e03..6b167c24cd4ac3678e3563c915688b48df9fbb00

Suspecting: https://chromium.googlesource.com/chromium/src/+/6b167c24cd4ac3678e3563c915688b48df9fbb00

@johntlee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.	

Kindly refer the attached screen cast.

Thank You!

Comment 2 by johntlee@chromium.org, Dec 17 

Fixed:
Screenshot from 2018-12-17 11-07-01.png
12.5 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9dc587c472430010ac58045ea5fc971c9a6ab3a

commit c9dc587c472430010ac58045ea5fc971c9a6ab3a
Author: John Lee <johntlee@chromium.org>
Date: Tue Dec 18 03:42:37 2018

Settings WebUI: Add separator line for 'Manage search engines' row

Bug:  915581 
Change-Id: Ib093bfd9630732e3d6653c21222b5ee123699eee
Reviewed-on: https://chromium-review.googlesource.com/c/1380791
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617370}
[modify] https://crrev.com/c9dc587c472430010ac58045ea5fc971c9a6ab3a/chrome/browser/resources/settings/search_page/search_page.html

Comment 4 by rp...@virtusa.com, Dec 18

Labels: TE-Verified-M73 TE-Verified-73.0.3644.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.2) using latest Canary build : 73.0.3644.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mov
2.5 MB View Download

Comment 5 by johntlee@chromium.org, Dec 18

Status: Verified (was: Assigned)
►

Sign in to add a comment