MacPWAs: Reparent tab when installing PWA |
||
Issue descriptionWhen installing a PWA, the PWA does not actually start -- rather, it is just shown in the finder. The code to start the app is blocked by an #ifdef guard at [0]. When the guard removed, the app fails to launch. The reason for this is that the AppShim bundle has not finished being created. In particular, we have called CreateShortcuts [1], but that posts a task to load the resources required and then call CreateShortcutsWithInfo. To fix this, we'll need to somehow track that an application is in the process of creating its shortcuts and "hold off" on trying to launch until the creation is done. [0] https://cs.chromium.org/chromium/src/chrome/browser/extensions/bookmark_app_helper.cc?rcl=4f97d33cf6f9c655a18dfb191d1e8efea668393e&l=534 [1] https://cs.chromium.org/chromium/src/chrome/browser/web_applications/extensions/web_app_extension_shortcut.cc?rcl=4f97d33cf6f9c655a18dfb191d1e8efea668393e&l=266
,
Jan 7
|
||
►
Sign in to add a comment |
||
Comment 1 by ccameron@chromium.org
, Dec 17