New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 915571 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacPWAs: Reparent tab when installing PWA

Project Member Reported by ccameron@chromium.org, Dec 17

Issue description

When installing a PWA, the PWA does not actually start -- rather, it is just shown in the finder.

The code to start the app is blocked by an #ifdef guard at [0].

When the guard removed, the app fails to launch. The reason for this is that the AppShim bundle has not finished being created. In particular, we have called CreateShortcuts [1], but that posts a task to load the resources required and then call CreateShortcutsWithInfo.

To fix this, we'll need to somehow track that an application is in the process of creating its shortcuts and "hold off" on trying to launch until the creation is done.

[0] https://cs.chromium.org/chromium/src/chrome/browser/extensions/bookmark_app_helper.cc?rcl=4f97d33cf6f9c655a18dfb191d1e8efea668393e&l=534

[1] https://cs.chromium.org/chromium/src/chrome/browser/web_applications/extensions/web_app_extension_shortcut.cc?rcl=4f97d33cf6f9c655a18dfb191d1e8efea668393e&l=266
 
Nice to have for M73. This might "come for free" with app signatures (or nearly for free), in which case we can do it for 73 (otherwise next release).
Status: Assigned (was: Untriaged)

Sign in to add a comment