New issue
Advanced search Search tips

Issue 915567 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[LayoutNG] CHECK failure in NGLineBreaker::BreakText

Project Member Reported by kojii@chromium.org, Dec 17

Issue description

What steps will reproduce the problem?
(1) Open https://dictionnaire.reverso.net/francais-definition/permanence

From an investigation at #9 in issue 900898.

Report ID 52fbd64d8c62a1b1


 
Summary: [LayoutNG] CHECK failure in NGLineBreaker::BreakText (was: [LayoutNG] Crash in NGLineBreaker::BreakText)
There are several different stable signature, but from random sampling, most of them are from the same CHECK failure.

https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name+LIKE+%27blink%3A%3ANGLineBreaker%3A%3ABreakText%25%27+and+product.version+%3E%3D+%2772.0.3603%27
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/971045a9135027671906556f210c27d8b6bed911

commit 971045a9135027671906556f210c27d8b6bed911
Author: Koji Ishii <kojii@chromium.org>
Date: Mon Dec 17 18:14:18 2018

[LayoutNG] Fix crash in NGLineBreaker for RTL

This patch fixes a crash in NGLineBreaker for RTL.

https://dictionnaire.reverso.net/anglais-francais/weirdo
causes a crash because one of ShapeResult in NGInlienItem
contains 0 characters. This was caused by an optimization
to find runs in ShapeResult sometimes fails to find the run.

Added more DCHECK in NGInlineNode::ShapeText to ensure
ShapeResult are good before it exits.

Bug: 900898,  915567 
Change-Id: I2e5023b5602d94ea8af43d665639553b1658e0c5
Reviewed-on: https://chromium-review.googlesource.com/c/1379610
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617160}
[modify] https://crrev.com/971045a9135027671906556f210c27d8b6bed911/third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
[modify] https://crrev.com/971045a9135027671906556f210c27d8b6bed911/third_party/blink/renderer/platform/fonts/shaping/harfbuzz_shaper_test.cc
[modify] https://crrev.com/971045a9135027671906556f210c27d8b6bed911/third_party/blink/renderer/platform/fonts/shaping/shape_result.cc

Status: Fixed (was: Assigned)

Sign in to add a comment