Issue metadata
Sign in to add a comment
|
ChromeVox i18n message file $1 $2 placeholders should be wrapped in a <ph> element |
||||||||||||||||||||||||
Issue description./chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd contains messages containing $1 $2 etc, example <message desc="summarizes a table cell." name="IDS_CHROMEVOX_CELL_SUMMARY"> row $1 column $2 </message> Placeholder elements like $1 $2, should be wrapped in <ph> elements according to the docs [1] [2] [1] https://sites.google.com/a/chromium.org/dev/developers/design-documents/ui-localization#TOC-How-to-add-a-string [2] https://sites.google.com/a/chromium.org/dev/developers/tools-we-use-in-chromium/grit/grit-users-guide#Adding_Resources along with and <ex> element giving an example. <ph name="USER_EMAIL">$2<ex>foo@example.com</ex></ph> When this is not done, applications can fail to work when reading the i18n translated strings, sadly. There are 9 instances of this error in chromevox_strings.grd. Can we please fix?
,
Dec 18
Adding UI>Accessibility>ChromeVox
,
Dec 19
+chromevox owners
,
Dec 19
,
Dec 21
,
Dec 21
This is blocking 916858. I will not provide <ex> elements for the placeholders that are missing a <ph> in hromevox_strings.grd, but I can at least add the basic <ph> element required.
,
Dec 21
,
Dec 21
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a2e5403b464f518798021da8e61d7084a32cd18 commit 2a2e5403b464f518798021da8e61d7084a32cd18 Author: Noel Gordon <noel@chromium.org> Date: Fri Dec 21 11:10:39 2018 ChromeVox i18n message placeholders should be wrapped in a <ph> Placeholders like $1, $2 etc must be wrapped in a <ph> element, per the chromium i18n docs [1][2]. [1] https://sites.google.com/a/chromium.org/dev/developers/design-documents/ui-localization#TOC-How-to-add-a-string [2] https://sites.google.com/a/chromium.org/dev/developers/tools-we-use-in-chromium/grit/grit-users-guide#Adding_Resources Placeholders should have UPPERCASE "name" attribute and provide an <ex> example element (to give translators more context), but I will leave the <ex> out: folks working in the ally area could add them in future since they'd known much more about these i18 messages and their meanings. Cell summary elements 'name' attributes are not arbitrary - use these lower case attribute names for them tableCellColumnIndex, tableCellRowIndex to satify the browser_test and interactive_ui_test suites. Bug: 915561 Tbr: dtseng@ Change-Id: I41235ec7260539c0ff88f21c9a6e1f2644fdea1c Reviewed-on: https://chromium-review.googlesource.com/c/1388349 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#618497} [modify] https://crrev.com/2a2e5403b464f518798021da8e61d7084a32cd18/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
,
Dec 21
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by noel@chromium.org
, Dec 17