New issue
Advanced search Search tips

Issue 915558 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain

Blocking:
issue 878565



Sign in to add a comment

Add kevin64 to chrome pfq

Project Member Reported by manojgupta@chromium.org, Dec 17

Issue description

Adding to pfq will ensure that chrome prebuilts are available to devs and any local development would be easier.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9097c295730dd2af26f81994ebad0d2c601af49f

commit 9097c295730dd2af26f81994ebad0d2c601af49f
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Dec 17 18:31:17 2018

Chromeos_config: Add kevin64 to pfq/cq:

Add kevin64 to chrome pfq as an experimental builder.
kevin64-paladin also needs to be added other the unit test complains.

Adding to PFQ will help in catching regressions on arm64.
And ensures that chrome prebuilts are available to developers.

BUG=chromium:915558
TEST=pre-cq passes

Change-Id: Ic1e34774321837913030f6e0a4a229825781fc63
Reviewed-on: https://chromium-review.googlesource.com/1378915
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/9097c295730dd2af26f81994ebad0d2c601af49f/config/chromeos_config.py
[modify] https://crrev.com/9097c295730dd2af26f81994ebad0d2c601af49f/config/waterfall_layout_dump.txt
[modify] https://crrev.com/9097c295730dd2af26f81994ebad0d2c601af49f/config/config_dump.json

Cc: dverkamp@chromium.org dgarr...@chromium.org
Status: Assigned (was: Untriaged)
Possibly related:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8926828009649903248

https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8926828009649903248/+/steps/BuildPackages/0/stdout

kevin64-paladin failed [kevin64-paladin/R73-11422.0.0-rc1] in BuildPackages due to missing prebuilts for chromeos-base/chromeos-chrome:

22:04:50: ERROR: Cannot find prebuilts for chromeos-base/chromeos-chrome on kevin64
22:04:50: INFO: Translating result Cannot find prebuilts for chromeos-base/chromeos-chrome on kevin64 to fail.
kevin64-paladin is experimental so won't impact CQ.

The missing prebuilts for chromeos-chrome will be fixed once master-chromium-pfq has a successful run.
Owner: dgarr...@chromium.org
Oh, looks like master-chromium-pfq had a successful run but it didn't upload kevin64 chrome prebuilts.

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8926801015891595504

kevin64 is missing from the list of boards when uploading prebuilts.
https://logs.chromium.org/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8926801015891595504/+/steps/PublishUprevChanges/0/stdout

Hopefully dgarrett@ knows what is needed to make master-chromium-pfq to upload kevin64 prebuilts.
The kevin64 pfq builder is currently experimental, it probably won't upload until it's marked as important. Prepping a CL.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a551db08c7bd091e7196974d177a6aa13fc7e2b4

commit a551db08c7bd091e7196974d177a6aa13fc7e2b4
Author: Don Garrett <dgarrett@google.com>
Date: Wed Dec 19 19:54:45 2018

chromeos_config: Mark kevin64 important in Chrome PFQ.

This marks the kevin64 builder in the Chrome PFQ important, so that
Chrome prebuilts will be uploaded. This is required to mark the
kevin64 CQ builder as important.

BUG=chromium:915558
TEST=chromeos_config_unittest
     kevin64 experimental PFQ has been passing.

Change-Id: I5308773e404fd98137f37c5e6bb914177c537a0d
Reviewed-on: https://chromium-review.googlesource.com/1382939
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>

[modify] https://crrev.com/a551db08c7bd091e7196974d177a6aa13fc7e2b4/config/chromeos_config.py
[modify] https://crrev.com/a551db08c7bd091e7196974d177a6aa13fc7e2b4/config/config_dump.json

Cc: amoylan@chromium.org
After the next PFQ success, I expect kevin64 builds to start passing. If the paladin builder turns green, we can mark it as important as well.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/90ff2236aeea9a3cfd9d3935746b6fee36c9e01b

commit 90ff2236aeea9a3cfd9d3935746b6fee36c9e01b
Author: Don Garrett <dgarrett@chromium.org>
Date: Fri Dec 21 01:45:26 2018

Revert "chromeos_config: Mark kevin64 important in Chrome PFQ."

This reverts commit a551db08c7bd091e7196974d177a6aa13fc7e2b4.

Reason for revert: This builder is now failing, and blocking PFQ uprev, for unknown reasons.

Original change's description:
> chromeos_config: Mark kevin64 important in Chrome PFQ.
>
> This marks the kevin64 builder in the Chrome PFQ important, so that
> Chrome prebuilts will be uploaded. This is required to mark the
> kevin64 CQ builder as important.
>
> BUG=chromium:915558
> TEST=chromeos_config_unittest
>      kevin64 experimental PFQ has been passing.
>
> Change-Id: I5308773e404fd98137f37c5e6bb914177c537a0d
> Reviewed-on: https://chromium-review.googlesource.com/1382939
> Commit-Ready: Don Garrett <dgarrett@chromium.org>
> Tested-by: Don Garrett <dgarrett@chromium.org>
> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>

Bug: chromium:915558
Change-Id: I78a62a895b6230a2d80b725b9b5d0163c2c34ffb
Reviewed-on: https://chromium-review.googlesource.com/1387869
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>

[modify] https://crrev.com/90ff2236aeea9a3cfd9d3935746b6fee36c9e01b/config/chromeos_config.py
[modify] https://crrev.com/90ff2236aeea9a3cfd9d3935746b6fee36c9e01b/config/config_dump.json

Sign in to add a comment