New issue
Advanced search Search tips

Issue 915546 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 736308



Sign in to add a comment

PDF documents not showing in Incognito mode

Reported by kwpol...@gmail.com, Dec 16

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3639.1 Safari/537.36

Example URL:
https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf

Steps to reproduce the problem:
1. Open any PDF document in Incognito mode.
2. The grey background of the viewer appears, but no document.

What is the expected behavior?

What went wrong?
The document does not display in Incognito mode. Everything works fine in standard mode.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes Last week’s.

Does this work in other browsers? Yes

Chrome version: 73.0.3639.1  Channel: dev
OS Version: OS X 10.14.2
Flash Version:
 
Components: -Blink Internals>Plugins>PDF
Labels: -Type-Bug Needs-Bisect Type-Bug-Regression
Cc: vamshi.kommuri@chromium.org
Labels: Needs-Feedback Triaged-ET
Thanks for filing the issue!

Unable to reproduce the issue on reported chrome version 73.0.3639.1 using Mac 10.14.1 with the below mentioned steps.
1. Launched Chrome
2. Navigated to https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf in incognito mode.
We were able to view PDF document without any issues. Attaching the screen shot of the same for reference.

@Reporter: Could you please share a screenshot of the issue and let us know if we have missed anything in the process. 
915546.png
273 KB View Download
The bug occurs in the presence of "OutOfBlinkCors" (bug 905971), which is automatically enabled for random users.
TE@, to emulate this you can add "--enable-features=OutOfBlinkCors" to chrome command line.

Bisected to r616406 = b40eb5f558d94b70ea763e00664e5ea6b706ab74 = https://crrev.com/c/1375295 by dstockwell@google.com
"Reland "pdf: Introduce content controller abstraction""
Landed in 73.0.3640.0

Confirmed by reverting the changed file inside resources.pak and observing no bug.
Labels: -Needs-Feedback -Needs-Bisect
Owner: dstockwell@google.com
Status: Started (was: Unconfirmed)
Cc: dstockwell@google.com
Components: Blink>SecurityFeature>CORS
Labels: OOR-CORS OS-Linux
Owner: toyoshim@chromium.org
Status: Assigned (was: Started)
Seems my patch may have changed the loading order, causing the PDF viewer to become *more* broken when OutOfBlinkCors is enabled.

However, the PDF viewer is broken before my change, due to OutOfBlinkCors. Even with the above patch revered many resources fail to load, and the PDF viewer's toolbar (controls to print/save) is absent.

An example error:

Access to imported resource at 'chrome://resources/html/polymer.html' from origin 'chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'null' that is not equal to the supplied origin.
chrome://resources/html/polymer.html:1 Failed to load resource: net::ERR_FAILED

But this should be allowed due to the manifest entry in chrome/browser/resources/pdf/manifest.json

 "permissions": [
    "chrome://resources/",
    ...
As per c#5 bisected with --enable-features=OutOfBlinkCors,OutOfBlinkCORS
to r513425 = b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b = https://crrev.com/c/735242 by toyoshim@chromium.org
"CORSURLLoader: Implement CORS response header checks"
Landed in 64.0.3257.0
Blocking: 736308
Labels: OS-Chrome

Comment 8 by thestig@chromium.org, Jan 16 (6 days ago)

Cc: thestig@chromium.org viswa.karala@chromium.org
 Issue 922289  has been merged into this issue.

Sign in to add a comment