Issue metadata
Sign in to add a comment
|
NavigationPredictorBrowserTest.ActionAccuracy_DifferentOrigin_VisibilityChanged is flaky |
||||||||||||||||||||||
Issue descriptionFindit identified the culprit r615163 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMWUwYjJlOGEyZjg0OTBkZTk1MTVjNzMxMjBiMTY2NzBiYTE3YjMwZgw Please revert the culprit, or disable the test(s) and find the appropriate owner to fix or delete. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r615163&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMWUwYjJlOGEyZjg0OTBkZTk1MTVjNzMxMjBiMTY2NzBiYTE3YjMwZgw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Dec 17
I'm reverting.
Failure is
[7564:4792:1216/043434.736:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[7564:4928:1216/043434.930:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc(410): error: Expected equality of these values:
0u
Which is: 0
accepted_socket_count()
Which is: 1
Stack trace:
Backtrace:
testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0000000140645F47+87]
testing::internal::AssertHelper::operator= [0x0000000140645ACE+78]
NavigationPredictorBrowserTest_ActionAccuracy_DifferentOrigin_VisibilityChanged_Test::RunTestOnMainThread [0x000000013F863984+1460]
content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x000000014277380D+445]
ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00000001435CF4DA+4650]
ChromeBrowserMainParts::PreMainMessageLoopRun [0x00000001435CE1F3+147]
content::BrowserMainLoop::PreMainMessageLoopRun [0x00000001410FE706+54]
content::StartupTaskRunner::RunAllTasksNow [0x0000000141441DCB+43]
content::BrowserMainLoop::CreateStartupTasks [0x00000001410FD4EB+587]
content::BrowserMainRunnerImpl::Initialize [0x00000001411007EB+107]
content::BrowserMain [0x00000001410FB99C+156]
content::RunBrowserProcessMain [0x000000014230CB4F+111]
content::ContentMainRunnerImpl::RunServiceManager [0x000000014230D63A+762]
content::ContentMainRunnerImpl::Run [0x000000014230D30E+238]
service_manager::Main [0x0000000142F51507+551]
content::ContentMain [0x000000014230CA7E+62]
content::BrowserTestBase::SetUp [0x0000000142773514+1796]
InProcessBrowserTest::SetUp [0x00000001425BD34D+429]
subresource_filter::SubresourceFilterBrowserTest::SetUp [0x000000013FBCDB1A+106]
NavigationPredictorBrowserTest::SetUp [0x000000013F86605A+346]
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce2ff3b6610aa28af22b34ea6c6fc0283bdbd924 commit ce2ff3b6610aa28af22b34ea6c6fc0283bdbd924 Author: David Roger <droger@chromium.org> Date: Mon Dec 17 10:15:27 2018 Revert "Preconnect to the main frame origin" This reverts commit 1e0b2e8a2f8490de9515c73120b16670ba17b30f. Reason for revert: NavigationPredictorBrowserTest.ActionAccuracy_DifferentOrigin_VisibilityChanged is flaky Bug: 915526 Original change's description: > Preconnect to the main frame origin > > Logic to preconnect to the main frame origin when > app or tab is brought to the foreground. > > The preconnect action is behind a finch trial, and is disabled > by default. > > Change-Id: I0fb183d75997c702585b294da59016131b254683 > Bug: 908725 > Reviewed-on: https://chromium-review.googlesource.com/c/1365076 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615163} TBR=pasko@chromium.org,tbansal@chromium.org,ryansturm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 908725 Change-Id: I2aa0d83d1ebb56cc4539d3a575fae66856d69983 Reviewed-on: https://chromium-review.googlesource.com/c/1379757 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#617073} [modify] https://crrev.com/ce2ff3b6610aa28af22b34ea6c6fc0283bdbd924/chrome/browser/navigation_predictor/navigation_predictor.cc [modify] https://crrev.com/ce2ff3b6610aa28af22b34ea6c6fc0283bdbd924/chrome/browser/navigation_predictor/navigation_predictor.h [modify] https://crrev.com/ce2ff3b6610aa28af22b34ea6c6fc0283bdbd924/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc [modify] https://crrev.com/ce2ff3b6610aa28af22b34ea6c6fc0283bdbd924/chrome/browser/navigation_predictor/navigation_predictor_unittest.cc [modify] https://crrev.com/ce2ff3b6610aa28af22b34ea6c6fc0283bdbd924/chrome/browser/predictors/loading_predictor_config.h
,
Dec 17
,
Dec 17
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shimazu@chromium.org
, Dec 17Owner: tbansal@chromium.org
Status: Assigned (was: Untriaged)