New issue
Advanced search Search tips

Issue 915501 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

"Manage audio focus across tabs" issue not working

Reported by kyp...@gmail.com, Dec 16

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3641.0 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. enable #Manage audio focus across tabs
2. play a video 
3. play another video expecting the first video to pause

What is the expected behavior?
videos are not pausing with #Manage audio focus across tabs enabled 

What went wrong?
Before when you enable #Manage audio focus across tabs in options it would pause a video if a new video was opened now it doesn't do anything.

Did this work before? Yes two weeks ago

Is it a problem with Flash or HTML5? N/A

Does this work in other browsers? N/A

Chrome version: 73.0.3641.0  Channel: n/a
OS Version: 10.0
Flash Version: 

Contents of chrome://gpu: 
Graphics Feature Status
Canvas: Hardware accelerated
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Enabled
Native GpuMemoryBuffers: Software only. Hardware acceleration disabled
Out-of-process Rasterization: Unavailable
Hardware Protected Video Decode: Hardware accelerated
Rasterization: Hardware accelerated
Skia Renderer: Disabled
Surface Control: Disabled
Surface Synchronization: Enabled
Video Decode: Hardware accelerated
Viz Service Display Compositor: Disabled
WebGL: Hardware accelerated
WebGL2: Hardware accelerated
 
Labels: Needs-Triage-M73 Needs-Bisect
Cc: santhoshkumar@chromium.org
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET Target-72 Target-73 M-72 FoundIn-73 FoundIn-72 hasbisect OS-Linux OS-Mac Pri-1
Owner: beccahughes@chromium.org
Able to reproduce the issue on reported chrome version #73.0.3641.0  by following steps as per comment#0 using Windows 10, Ubuntu 17.10 and Mac OS 10.13.6.The following is the bisect information.

Bisect information:
==============
Good Build: 72.0.3624.0
Bad Build: 72.0.3625.0

Change Log: https://chromium.googlesource.com/chromium/src/+log/2bebff9b8acbe7bf3e75c0ba6e39392ec940d932..d84875638d699d0110af1f958c8157cb11f4d4db
Suspecting: https://chromium.googlesource.com/chromium/src/+/31479d428fd82fcbdedfa839508ff0196a618f93
Reviewed-on: https://chromium-review.googlesource.com/c/1342939

@ Becca Hughes: Please help us in re-assigning if this is not related to your change.
Adding Release-Block-Stable as this is recent regression. Please feel free to remove if not applicable.

Thanks.!
Status: Assigned (was: Unconfirmed)
++ Correction 
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Unmarking as RBS as audio focus is not a supported feature.
Cc: beccahughes@chromium.org mlamouri@chromium.org
 Issue 915500  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/858e896df6c8fc660b3a610710272d2b65005fde

commit 858e896df6c8fc660b3a610710272d2b65005fde
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Dec 19 11:37:25 2018

[Audio Focus] Restrict browser group to CrOS

Restrict browser audio focus grouping to Chrome OS.

BUG= 915501 

Change-Id: I702952cca7a388e78c201531866307797d25b277
Reviewed-on: https://chromium-review.googlesource.com/c/1379918
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617800}
[modify] https://crrev.com/858e896df6c8fc660b3a610710272d2b65005fde/content/browser/media/session/audio_focus_delegate_default.cc
[modify] https://crrev.com/858e896df6c8fc660b3a610710272d2b65005fde/content/browser/media/session/audio_focus_delegate_default_browsertest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194616577b6224c99888e2de86f01070772b54f8

commit 194616577b6224c99888e2de86f01070772b54f8
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Dec 20 09:02:58 2018

Revert "[Audio Focus] Restrict browser group to CrOS"

This reverts commit 858e896df6c8fc660b3a610710272d2b65005fde.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Audio Focus] Restrict browser group to CrOS
> 
> Restrict browser audio focus grouping to Chrome OS.
> 
> BUG= 915501 
> 
> Change-Id: I702952cca7a388e78c201531866307797d25b277
> Reviewed-on: https://chromium-review.googlesource.com/c/1379918
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617800}

TBR=mlamouri@chromium.org,beccahughes@chromium.org

Change-Id: Iea619a6c60bda9db345405501271117e5fb828c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  915501 
Reviewed-on: https://chromium-review.googlesource.com/c/1386204
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618144}
[modify] https://crrev.com/194616577b6224c99888e2de86f01070772b54f8/content/browser/media/session/audio_focus_delegate_default.cc
[modify] https://crrev.com/194616577b6224c99888e2de86f01070772b54f8/content/browser/media/session/audio_focus_delegate_default_browsertest.cc

issue has been fixed in the new update on Canary thank you everyone!
Update today broke this feature again. Nothing is pausing. 

Latest Canary update broken this feature again. 
still broken
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4b3b9510bedf1eb53e2b12d5c2642d501da2d24

commit d4b3b9510bedf1eb53e2b12d5c2642d501da2d24
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jan 03 20:54:12 2019

Reland "[Audio Focus] Restrict browser group to CrOS"

This is a reland of 858e896df6c8fc660b3a610710272d2b65005fde

Original change's description:
> [Audio Focus] Restrict browser group to CrOS
>
> Restrict browser audio focus grouping to Chrome OS.
>
> BUG= 915501 
>
> Change-Id: I702952cca7a388e78c201531866307797d25b277
> Reviewed-on: https://chromium-review.googlesource.com/c/1379918
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617800}

Bug:  915501 
Change-Id: Ideb9814a6d4ff7e9faedc66efa6d2073adec818d
Reviewed-on: https://chromium-review.googlesource.com/c/1386107
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619747}
[modify] https://crrev.com/d4b3b9510bedf1eb53e2b12d5c2642d501da2d24/chrome/browser/web_applications/extensions/web_app_audio_focus_browsertest.cc
[modify] https://crrev.com/d4b3b9510bedf1eb53e2b12d5c2642d501da2d24/content/browser/media/session/audio_focus_delegate_default.cc
[modify] https://crrev.com/d4b3b9510bedf1eb53e2b12d5c2642d501da2d24/content/browser/media/session/audio_focus_delegate_default_browsertest.cc
[modify] https://crrev.com/d4b3b9510bedf1eb53e2b12d5c2642d501da2d24/media/base/media_switches.cc
[modify] https://crrev.com/d4b3b9510bedf1eb53e2b12d5c2642d501da2d24/media/base/media_switches.h

its working again in the latest Canary build thank you.
It just broke in the latest Canary patch. Very sad. Any reason why it gets fixed and then comes back? Happened 3 times now it gets fixed and then someone reverts it back seems like. 
It's not broken, the switch was removed and replaced with a feature:

 --enable-features=MediaSessionService,AudioFocusEnforcement

Sign in to add a comment