unable upload file and image from file chooser
Reported by
youling...@gmail.com,
Dec 15
|
||||||||||||
Issue descriptionSteps to reproduce the problem: 1. 2. 3. What is the expected behavior? What went wrong? chrome canary 73.0.3640.0 and 73.0.3641.0, unable upload file and image from file chooser, chrome canary 73.0.3639.0 no this problem. Did this work before? N/A Chrome version: 73.0.3641.0 Channel: canary OS Version: 7.1.2 Flash Version:
,
Dec 15
73.0.3641.0
,
Dec 17
,
Dec 17
Tested the issue in Android and able to reproduce the issue. Steps Followed: 1. Navigated to https://cgi-lib.berkeley.edu/ex/fup.html 2. Uploaded file and Observed cant upload file error page. Chrome versions tested: 73.0.3642.0(Canary) OS: Android 9 Android Devices: Pixel XL Unable to provide bisect info, as this issue is only seen in canary builds, installing equivalent dev builds doesn't have this issue.Hence marking this issue as untriaged for further inputs from dev team & adding labels accordingly. Thanks!
,
Dec 17
,
Dec 17
Fix up for review for this in http://crrev.com/c/1381111
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c82a54380ea7e7b1bac9b5245c4b0843802d8f59 commit c82a54380ea7e7b1bac9b5245c4b0843802d8f59 Author: Clark DuVall <cduvall@chromium.org> Date: Mon Dec 17 23:26:57 2018 Fix file uploads on Android when Network Service is enabled Android uses content:// URIs for file uploads, which we were not handling in network service. This changes the code that opens the files to open content:// URIs correctly. Bug: 915484 Change-Id: I56f5510020cb11b5e405df2f59a7109a43e0f683 Reviewed-on: https://chromium-review.googlesource.com/c/1381111 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#617280} [modify] https://crrev.com/c82a54380ea7e7b1bac9b5245c4b0843802d8f59/content/browser/network_service_client.cc [modify] https://crrev.com/c82a54380ea7e7b1bac9b5245c4b0843802d8f59/content/browser/network_service_client_unittest.cc
,
Dec 18
Verified this in the latest canary, version 73.0.3644.0. Requesting merge to M72, this is a network service only change to fix uploads.
,
Dec 18
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 18
,
Dec 18
Approving merge to M72 branch 3626 based on comment #8. Please merge ASAP. Thank you.
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93a38f9d9016d3be774b0da017ae7f2561ad5b8b commit 93a38f9d9016d3be774b0da017ae7f2561ad5b8b Author: Clark DuVall <cduvall@chromium.org> Date: Tue Dec 18 19:05:28 2018 Fix file uploads on Android when Network Service is enabled Android uses content:// URIs for file uploads, which we were not handling in network service. This changes the code that opens the files to open content:// URIs correctly. Bug: 915484 Change-Id: I56f5510020cb11b5e405df2f59a7109a43e0f683 Reviewed-on: https://chromium-review.googlesource.com/c/1381111 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617280}(cherry picked from commit c82a54380ea7e7b1bac9b5245c4b0843802d8f59) Reviewed-on: https://chromium-review.googlesource.com/c/1382869 Reviewed-by: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#439} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/93a38f9d9016d3be774b0da017ae7f2561ad5b8b/content/browser/network_service_client.cc [modify] https://crrev.com/93a38f9d9016d3be774b0da017ae7f2561ad5b8b/content/browser/network_service_client_unittest.cc
,
Dec 18
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93a38f9d9016d3be774b0da017ae7f2561ad5b8b Commit: 93a38f9d9016d3be774b0da017ae7f2561ad5b8b Author: cduvall@chromium.org Commiter: cduvall@chromium.org Date: 2018-12-18 19:05:28 +0000 UTC Fix file uploads on Android when Network Service is enabled Android uses content:// URIs for file uploads, which we were not handling in network service. This changes the code that opens the files to open content:// URIs correctly. Bug: 915484 Change-Id: I56f5510020cb11b5e405df2f59a7109a43e0f683 Reviewed-on: https://chromium-review.googlesource.com/c/1381111 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617280}(cherry picked from commit c82a54380ea7e7b1bac9b5245c4b0843802d8f59) Reviewed-on: https://chromium-review.googlesource.com/c/1382869 Reviewed-by: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#439} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by youling...@gmail.com
, Dec 15145 KB
145 KB View Download