New issue
Advanced search Search tips

Issue 915467 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

[vim/ycm] support for jumbo build

Reported by i...@vivaldi.com, Dec 15

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36 Vivaldi/2.1.1337.36

Steps to reproduce the problem:
The script tools/vim/chromium.ycm_extra_conf.py that configures YouCompleteMe for various IDE does not support jumbo builds, https://chromium.googlesource.com/chromium/src/+/master/docs/jumbo.md 

With a jumbo build enabled the script reverts to default build flags rather than printing flags for a jumbo chunk the file is in.

What is the expected behavior?
The tool properly extracts relevant compilation flags event when use_jumbo_build is set to true.

What went wrong?
The tool relies on ninja -t query to get the build target. Unfortunately this does not work for jumbo build as there C++ sources essentially treated as header files included into particular jumbo file and the ninja query tool gives nothing then.

Did this work before? No 

Chrome version: 72  Channel: beta
OS Version: Ubuntu 18.04
Flash Version: 

A possible workaround is to replace ninja -t query with ninja -t deps. The plus of this is that the flags for the header files will be properly detected. The minus is that ninja -t deps takes 2 seconds on a fast Linux laptop.
 
Labels: Needs-Triage-M72
Cc: viswa.karala@chromium.org
Components: Build
Labels: Triaged-ET FoundIn-73 Target-73 M-73 FoundIn-71 FoundIn-72 OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Thanks for filing the issue!

As per comment# 0 from the reporter issue seems to be a Feature request, hence marking it as Untriaged.
Note: Tentatively adding Build component to this issue.

Thanks!

Sign in to add a comment