Issue metadata
Sign in to add a comment
|
PointerTest.SetCursorAndSetCursorType is flaky |
||||||||||||||||||||||||
Issue descriptionFindit identified the culprit r616913 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjA5OTk3ZmU2MDBiOTYzYjQ4MzBjMmE3MTNiZTY4MzlmMTg1NjIwOQw Please revert the culprit, or disable the test(s) and find the appropriate owner to fix or delete. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r616913&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjA5OTk3ZmU2MDBiOTYzYjQ4MzBjMmE3MTNiZTY4MzlmMTg1NjIwOQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Dec 17
The test is already disabled for ASAN. I think it would make more sense to disable the test for MSAN too.
,
Dec 17
Also, a better fix: https://chromium-review.googlesource.com/c/chromium/src/+/1379273
,
Dec 17
Thanks for working on this. Stopped to send the revert to CQ.
,
Dec 17
Taking this out of the sheriff queue.
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/871ad195f267c3e1158c5c70ff2f6f296108782a commit 871ad195f267c3e1158c5c70ff2f6f296108782a Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Dec 18 06:24:03 2018 exo: Fix receiving presentation feedback. It is possible for the SurfaceTreeHost to submit a frame, then have its root-surface reset, before it receives the corresponding presentation timestamp for the submitted frame. However, when the root-surface is reset, the presentation-callbacks are removed. So when the presentation timestamp is ultimately received, the callback is no longer available. Handle such cases gracefully. BUG= 915458 Change-Id: I7b0fd329f0e108c0e47884e22a64d1979b1ec5fe Reviewed-on: https://chromium-review.googlesource.com/c/1379273 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#617393} [modify] https://crrev.com/871ad195f267c3e1158c5c70ff2f6f296108782a/components/exo/surface_tree_host.cc
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c6003d8e840fad2f96411bb1d931a99c3e9148c commit 4c6003d8e840fad2f96411bb1d931a99c3e9148c Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Thu Dec 20 23:22:14 2018 exo: Add a test for crrev.com/c/1379273 Add a test to make sure that already removed presentation callbacks for submitted compositor frames do not cause crashes. BUG= 915458 Change-Id: Ia0ae709a6a6792564a01d3086369f32850cf14fb Reviewed-on: https://chromium-review.googlesource.com/c/1381778 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#618373} [modify] https://crrev.com/4c6003d8e840fad2f96411bb1d931a99c3e9148c/components/exo/pointer_unittest.cc [modify] https://crrev.com/4c6003d8e840fad2f96411bb1d931a99c3e9148c/components/exo/surface_tree_host.h
,
Dec 20
,
Dec 20
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by shimazu@chromium.org
, Dec 17Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)