New issue
Advanced search Search tips

Issue 915436 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Bad rendering on the snooze icon in swipe controls

Project Member Reported by sgabr...@chromium.org, Dec 15

Issue description

See the image attached. The right side of the circle forming the snooze icon is thinner than the left side. I think the asset needs to be checked. I've attached them to this bug
 
snooze.zip
1.7 KB Download
preview.png
25.9 KB View Download
Status: Started (was: Assigned)
A swipe control uses the same icon as the smaller one for mouse hover. ui/message_center/vector_icons/notification_snooze_button.icon
The resource has dedicated icons for 12 and 24 pixels.

It's scaled to 20px when displayed on the swipe controls.
https://cs.chromium.org/chromium/src/ash/system/message_center/message_center_style.h?q=kSwipeControlButtonImageSize&sq=package:chromium&g=0&l=25

Here are the screenshots with existing code and crrev.com/c/1379628.
I've found the smaller icon (mousehover) also has the same issue.
before.png
10.3 KB View Download
after.png
3.1 KB View Download
Screenshot with Patch Set 3.
2ndfix.png
2.8 KB View Download
Thanks a lot Yamaguchi!
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd3a21e77dfeae0ca1f3a59da404a8444df302a1

commit dd3a21e77dfeae0ca1f3a59da404a8444df302a1
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Jan 08 03:15:32 2019

Update notification snooze icon.

The old icon looked asymmetric when rendered. This will affect the both
icons for mouse hover and swipe control.

BUG= 915436 
TEST=manual, screenshot pasted on the bug

Change-Id: I2ea31b2d7bd4ee720d11ef4077300544fecba12c
Reviewed-on: https://chromium-review.googlesource.com/c/1379628
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620598}
[modify] https://crrev.com/dd3a21e77dfeae0ca1f3a59da404a8444df302a1/ui/message_center/vector_icons/notification_snooze_button.icon

Status: Fixed (was: Started)

Sign in to add a comment