New issue
Advanced search Search tips

Issue 915435 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Stack-overflow in v8::internal::ValueDeserializer::ReadObjectInternal

Project Member Reported by ClusterFuzz, Dec 15

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5673257816293376

Fuzzer: libFuzzer_v8_serialized_script_value_fuzzer
Fuzz target binary: v8_serialized_script_value_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7ffe9fda6fe0
Crash State:
  v8::internal::ValueDeserializer::ReadObjectInternal
  v8::internal::ValueDeserializer::ReadObject
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=609145:609147

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5673257816293376

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.
 
Project Member

Comment 1 by ClusterFuzz, Dec 15

Components: Blink>JavaScript
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 15

Labels: Test-Predator-Auto-Owner
Owner: yangguo@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/206b8e0851093e61cf22dc2af3f103df9f2de9b3 (Check array element length in ValueDeserializer).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d945ea76168c55b3f7c86651c0de7e3d6d42ff3c

commit d945ea76168c55b3f7c86651c0de7e3d6d42ff3c
Author: Yang Guo <yangguo@chromium.org>
Date: Mon Dec 17 10:21:18 2018

[value serializer] check for stack overflow for verify object count.

R=jgruber@chromium.org

Bug:  chromium:915435 
Change-Id: Ic5535adb2aa09ffc72bf4e50ff8ec624dea1909e
Reviewed-on: https://chromium-review.googlesource.com/c/1379932
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58270}
[modify] https://crrev.com/d945ea76168c55b3f7c86651c0de7e3d6d42ff3c/src/value-serializer.cc
[modify] https://crrev.com/d945ea76168c55b3f7c86651c0de7e3d6d42ff3c/test/unittests/value-serializer-unittest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Dec 18

ClusterFuzz has detected this issue as fixed in range 617122:617123.

Detailed report: https://clusterfuzz.com/testcase?key=5673257816293376

Fuzzer: libFuzzer_v8_serialized_script_value_fuzzer
Fuzz target binary: v8_serialized_script_value_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7ffe9fda6fe0
Crash State:
  v8::internal::ValueDeserializer::ReadObjectInternal
  v8::internal::ValueDeserializer::ReadObject
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=609145:609147
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=617122:617123

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5673257816293376

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Dec 18

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5673257816293376 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment