New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 915430 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocked on:
issue 901830



Sign in to add a comment

dawn_end2end_tests failing on Linux FYI Release (AMD R7 240)

Project Member Reported by sunn...@chromium.org, Dec 15

Issue description

First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28AMD%20R7%20240%29/2477

(Note: webgl_conformance_tests are also failing on this bot due to unrelated reasons -  issue 914976 .)

Swarming logs: https://chromium-swarm.appspot.com/task?id=41c33e4b617f9c10&refresh=10&show_raw=1

Failures look like this:
[ RUN      ] DepthStencilStateTest.DepthLess/Vulkan
Assertion failure at ../../third_party/dawn/src/dawn_native/vulkan/DeviceVk.cpp:87 (Device): false
[3604:3607:1213/175526.401318:429577955:ERROR:kill_posix.cc(84)] Unable to terminate process group 3713: No such process (3)
[53/85] DepthStencilStateTest.DepthLess/Vulkan (CRASHED)


 
Blockedon: 901830
Blocking: -901830
The root cause is that the Vulkan loader isn't installed on that machine, see https://bugs.chromium.org/p/chromium/issues/detail?id=915215 ideally this is fixed quickly so we don't have to remove Dawn from all Linux GPU FYI bots. If it stays red for too long we could revert https://chromium-review.googlesource.com/c/chromium/src/+/1373810

Instead of reverting https://chromium-review.googlesource.com/c/chromium/src/+/1373810 we could / should just refactor the test suites so that it temporarily isn't run on that bot. cwallez@ if this isn't resolved during Pacific time today would you consider doing that refactor and TBR'ing it to me? Thanks.

libvulkan1 just got added to the builder so let's wait until build 2496. If only some tests fail I'll suppress them tomorrow. Otherwise I'll do the refactor kbr@ asked.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/12a2f65c43f7b198f95ef85299295d35ab3f9fc5

commit 12a2f65c43f7b198f95ef85299295d35ab3f9fc5
Author: Corentin Wallez <cwallez@chromium.org>
Date: Tue Dec 18 12:57:10 2018

Suppress failure on GPU FYI Linux AMD Release (R7 240)

TBR=senorblanco@chromium.org
BUG= chromium:915430 

Change-Id: I57cc253eda45faa4c68a2cc012f594bc3514ae42
Reviewed-on: https://dawn-review.googlesource.com/c/3380
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/12a2f65c43f7b198f95ef85299295d35ab3f9fc5/src/tests/end2end/InputStateTests.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7922fe66cb4d963d8a1c43e08d3b3d1dd11cdd59

commit 7922fe66cb4d963d8a1c43e08d3b3d1dd11cdd59
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Dec 18 14:11:56 2018

Roll src/third_party/dawn 63220100145f..12a2f65c43f7 (1 commits)

https://dawn.googlesource.com/dawn.git/+log/63220100145f..12a2f65c43f7


git log 63220100145f..12a2f65c43f7 --date=short --no-merges --format='%ad %ae %s'
2018-12-18 cwallez@chromium.org Suppress failure on GPU FYI Linux AMD Release (R7 240)


Created with:
  gclient setdep -r src/third_party/dawn@12a2f65c43f7

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:915430 
TBR=cwallez@chromium.org

Change-Id: Ie109c5628b8c90c358146be27879e709e090fb09
Reviewed-on: https://chromium-review.googlesource.com/c/1382335
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#617477}
[modify] https://crrev.com/7922fe66cb4d963d8a1c43e08d3b3d1dd11cdd59/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/d23fdd3624d16665a68ab5d0af3efd61bff21260

commit d23fdd3624d16665a68ab5d0af3efd61bff21260
Author: Corentin Wallez <cwallez@chromium.org>
Date: Tue Dec 18 18:04:42 2018

Fix the suppression on OpenGL to not specify the GPU

The OpenGL backend doesn't expose PCI device and vendor IDs yet which
means that IsAMD() is always false, making the test not skipped.

TBR=senorblanco@chromium.org
BUG= chromium:915430 

Change-Id: Ic630080df442826b572cbd294978820109424229
Reviewed-on: https://dawn-review.googlesource.com/c/3381
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/d23fdd3624d16665a68ab5d0af3efd61bff21260/src/tests/end2end/InputStateTests.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/becb070528ce6bad9f6790f9e61c3b961277c535

commit becb070528ce6bad9f6790f9e61c3b961277c535
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Dec 18 20:23:07 2018

Roll src/third_party/dawn 12a2f65c43f7..d23fdd3624d1 (1 commits)

https://dawn.googlesource.com/dawn.git/+log/12a2f65c43f7..d23fdd3624d1


git log 12a2f65c43f7..d23fdd3624d1 --date=short --no-merges --format='%ad %ae %s'
2018-12-18 cwallez@chromium.org Fix the suppression on OpenGL to not specify the GPU


Created with:
  gclient setdep -r src/third_party/dawn@d23fdd3624d1

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:915430 
TBR=cwallez@chromium.org

Change-Id: Iefb6271e3fcffc0880de68929a9b31e951867fc2
Reviewed-on: https://chromium-review.googlesource.com/c/1382777
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#617605}
[modify] https://crrev.com/becb070528ce6bad9f6790f9e61c3b961277c535/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/2745f37875fb0a78e984d9f379df3c493d62613c

commit 2745f37875fb0a78e984d9f379df3c493d62613c
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Dec 19 13:36:53 2018

Suppress more failure on GPU FYI Linux AMD Release (R7 240)

Tests are run in this order: 1, 2, 3

After suppressing test 2, test 3 started failing on the builder, this
seems to point out that test 1 is leaving the driver in a bad state.

We add suppressions both 1 and 3 just to be safe.

TBR=senorblanco@chromium.org
BUG= chromium:915430 

Change-Id: Ie601b03f9e5038c623d8b7e009d2a9fb8086d181
Reviewed-on: https://dawn-review.googlesource.com/c/3420
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/2745f37875fb0a78e984d9f379df3c493d62613c/src/tests/end2end/InputStateTests.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32375067d6da178a34ebc99850689077cb9b6ca5

commit 32375067d6da178a34ebc99850689077cb9b6ca5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Dec 19 16:48:44 2018

Roll src/third_party/dawn 292c0c31f25c..2745f37875fb (2 commits)

https://dawn.googlesource.com/dawn.git/+log/292c0c31f25c..2745f37875fb


git log 292c0c31f25c..2745f37875fb --date=short --no-merges --format='%ad %ae %s'
2018-12-19 cwallez@chromium.org Suppress more failure on GPU FYI Linux AMD Release (R7 240)
2018-12-19 jiawei.shao@intel.com Add render pass color and depth stencil attachment descriptor


Created with:
  gclient setdep -r src/third_party/dawn@2745f37875fb

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:915430 
TBR=cwallez@chromium.org

Change-Id: Id368f1017be8e6faebf02e678029e7f57f6924c5
Reviewed-on: https://chromium-review.googlesource.com/c/1384346
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#617857}
[modify] https://crrev.com/32375067d6da178a34ebc99850689077cb9b6ca5/DEPS

Cc: cwallez@chromium.org
Labels: -Pri-3 Pri-1
Owner: enga@chromium.org
PrimitiveTopologyTest.PointList/OpenGL is still failing on Linux AMD:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28AMD%20R7%20240%29/2509

Assigning to enga@ to suppress it
Cc: -zmo@chromium.org kbr@chromium.org senorblanco@chromium.org
Owner: zmo@chromium.org
per cwallez: "We should remove the whole test suite, a new test fails each time we suppress one."
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c307eeb7414f90209b28af6929ae054f8a037612

commit c307eeb7414f90209b28af6929ae054f8a037612
Author: Zhenyao Mo <zmo@chromium.org>
Date: Thu Dec 20 01:03:20 2018

Remove dawn_end2end_tests from Linux/AMD

BUG= 915430 
TEST=GPU/FYI/AMD bot
R=cwallez@chromium.org

Change-Id: I71ddb7de938ead8850b9954cbd883fdf13ad0fd3
Reviewed-on: https://chromium-review.googlesource.com/c/1385345
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618050}
[modify] https://crrev.com/c307eeb7414f90209b28af6929ae054f8a037612/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/c307eeb7414f90209b28af6929ae054f8a037612/testing/buildbot/test_suite_exceptions.pyl

Status: Fixed (was: Assigned)

Sign in to add a comment