New issue
Advanced search Search tips

Issue 915417 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: http/tests/webmidi/midi-default-feature-policy.https.sub.html



Sign in to add a comment

http/tests/webmidi/midi-default-feature-policy.https.sub.html is flaky

Project Member Reported by Findit, Dec 15

Issue description

Cc: toyoshim@chromium.org
Components: Tests>Flaky
Owner: adithyas@chromium.org
Status: Assigned (was: Untriaged)
(chromium build sheriff)
Assigned to the author of the CL.
I'm going to mark the test as flaky.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d511114c7c3a69a32e239b316030bb04f1b3c93

commit 4d511114c7c3a69a32e239b316030bb04f1b3c93
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Mon Dec 17 05:49:27 2018

Mark as flaky: http/tests/webmidi/midi-default-feature-policy.https.sub.html

TBR=adithyas@chromium.org, toyoshim@chromium.org

No-Try: true
Bug:  915417 
Change-Id: Idba15c34ea31ad76b07d0bead3c44a3dbf3d44b5
Reviewed-on: https://chromium-review.googlesource.com/c/1379623
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617050}
[modify] https://crrev.com/4d511114c7c3a69a32e239b316030bb04f1b3c93/third_party/blink/web_tests/TestExpectations

Labels: -Sheriff-Chromium
Components: Blink>WebMIDI
Labels: M-73
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f42fae614d9ca56510a072d4ed6adb6f24184d0

commit 3f42fae614d9ca56510a072d4ed6adb6f24184d0
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Fri Dec 21 20:30:14 2018

[WebMIDI] Fix flakiness in midi-default-feature-policy.html

I changed the test in an earlier CL (https://crrev.com/c/1289955) to
use MojoInterfaceInterceptor to intercept mojo requests for the
MidiSessionProvider interface at the process level. However, the
interceptor's lifetime is tied to the frame in which it's created,
leading to some issues.

Bug:  915417 , 582328
Change-Id: I71e69d76454233c12e1b1e73f06ffc7525bc48ee
Reviewed-on: https://chromium-review.googlesource.com/c/1385020
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618583}
[modify] https://crrev.com/3f42fae614d9ca56510a072d4ed6adb6f24184d0/third_party/blink/web_tests/http/tests/resources/feature-policy-permissions-test.js

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e3cee0ebe28c9c4de1a9e7dc027cb9c38bf3b5d

commit 8e3cee0ebe28c9c4de1a9e7dc027cb9c38bf3b5d
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Dec 27 16:21:55 2018

[WebMIDI] Renable midi feature policy layout test

Test runs are passing consistently after fix
(https://crrev.com/c/1385020) landed.

Bug:  915417 
Change-Id: I6324103155450a907a06fd4dcf31a658355c1365
Tbr: toyoshim@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1391563
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619042}
[modify] https://crrev.com/8e3cee0ebe28c9c4de1a9e7dc027cb9c38bf3b5d/third_party/blink/web_tests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment